[PR #569] [MERGED] Allow pipeline writer to spit out Ogg directly, including when seeking #970

New issue

Closed

opened 2026-02-27 20:00:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/569
Author: @philippe44
Created: 1/21/2021
Status: ✅ Merged
Merged: 2/23/2021
Merged by: @sashahilton00

Base: dev ← Head: passthrough-v3

📝 Commits (1)

34bc286 ogg passthrough

📊 Changes

20 files changed (+405 additions, -99 deletions)

View changed files

📝 .gitignore (+4 -1)
📝 Cargo.lock (+1 -0)
📝 audio/Cargo.toml (+1 -0)
📝 audio/src/lewton_decoder.rs (+14 -17)
📝 audio/src/lib.rs (+65 -2)
📝 audio/src/libvorbis_decoder.rs (+16 -15)
➕ audio/src/passthrough_decoder.rs (+191 -0)
📝 playback/src/audio_backend/alsa.rs (+3 -1)
📝 playback/src/audio_backend/gstreamer.rs (+3 -2)
📝 playback/src/audio_backend/jackaudio.rs (+3 -2)
📝 playback/src/audio_backend/mod.rs (+2 -1)
📝 playback/src/audio_backend/pipe.rs (+10 -6)
📝 playback/src/audio_backend/portaudio.rs (+3 -2)
📝 playback/src/audio_backend/pulseaudio.rs (+8 -3)
📝 playback/src/audio_backend/rodio.rs (+3 -2)
📝 playback/src/audio_backend/sdl.rs (+3 -2)
📝 playback/src/audio_backend/subprocess.rs (+4 -3)
📝 playback/src/config.rs (+2 -0)
📝 playback/src/player.rs (+61 -40)
📝 src/main.rs (+8 -0)

📄 Description

Use ogg v 0.8 to use directly inner writer instead of the complicated workaround in previous patch https://github.com/librespot-org/librespot/pull/560

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/569 **Author:** [@philippe44](https://github.com/philippe44) **Created:** 1/21/2021 **Status:** ✅ Merged **Merged:** 2/23/2021 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `dev` ← **Head:** `passthrough-v3` --- ### 📝 Commits (1) - [`34bc286`](https://github.com/librespot-org/librespot/commit/34bc286d9b456c828300ce682ac083d4cfed0741) ogg passthrough ### 📊 Changes **20 files changed** (+405 additions, -99 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+4 -1) 📝 `Cargo.lock` (+1 -0) 📝 `audio/Cargo.toml` (+1 -0) 📝 `audio/src/lewton_decoder.rs` (+14 -17) 📝 `audio/src/lib.rs` (+65 -2) 📝 `audio/src/libvorbis_decoder.rs` (+16 -15) ➕ `audio/src/passthrough_decoder.rs` (+191 -0) 📝 `playback/src/audio_backend/alsa.rs` (+3 -1) 📝 `playback/src/audio_backend/gstreamer.rs` (+3 -2) 📝 `playback/src/audio_backend/jackaudio.rs` (+3 -2) 📝 `playback/src/audio_backend/mod.rs` (+2 -1) 📝 `playback/src/audio_backend/pipe.rs` (+10 -6) 📝 `playback/src/audio_backend/portaudio.rs` (+3 -2) 📝 `playback/src/audio_backend/pulseaudio.rs` (+8 -3) 📝 `playback/src/audio_backend/rodio.rs` (+3 -2) 📝 `playback/src/audio_backend/sdl.rs` (+3 -2) 📝 `playback/src/audio_backend/subprocess.rs` (+4 -3) 📝 `playback/src/config.rs` (+2 -0) 📝 `playback/src/player.rs` (+61 -40) 📝 `src/main.rs` (+8 -0) </details> ### 📄 Description Use ogg v 0.8 to use directly inner writer instead of the complicated workaround in previous patch https://github.com/librespot-org/librespot/pull/560 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:39 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#970

No description provided.

Rows
Columns