starred/librespot

Fork 0

mirror of https://github.com/librespot-org/librespot.git synced 2026-04-27 08:15:50 +03:00

[GH-ISSUE #113] Nightly feature flag non existent #97

New issue

Closed

opened 2026-02-27 19:28:49 +03:00 by kerem · 4 comments

kerem commented

2026-02-27 19:28:49 +03:00

Owner

Originally created by @ComlOnline on GitHub (Jan 31, 2018).
Original GitHub issue: https://github.com/librespot-org/librespot/issues/113

In the master branch of librespot the nightly flag does not exist, see here. However in the v0.2 branch from plietar we can see that it is still there, see here.

In the v0.2 branch this is the nightly flag:

nightly = ["serde_derive"]

Should it be added back in as an option or is it now unneeded and the wiki changed?

Originally created by @ComlOnline on GitHub (Jan 31, 2018). Original GitHub issue: https://github.com/librespot-org/librespot/issues/113 In the master branch of librespot the `nightly` flag does not exist, see [here](https://github.com/librespot-org/librespot/blob/master/Cargo.toml#L63). However in the v0.2 branch from plietar we can see that it is still there, see [here](https://github.com/plietar/librespot/blob/v0.2/Cargo.toml#L76). In the v0.2 branch this is the nightly flag: ``` nightly = ["serde_derive"] ``` Should it be added back in as an option or is it now unneeded and the wiki changed?

kerem closed this issue

2026-02-27 19:28:50 +03:00

kerem commented

2026-02-27 19:28:50 +03:00

Author

Owner

@sashahilton00 commented on GitHub (Feb 1, 2018):

i don't believe it does anything in the current version, though @plietar would be the best person to talk to about that. the v0.2 branch was the beginning of a rewrite for librespot, but serde_derive doesn't look to do much, given that Serialize and Deserialize are already in use from the serde_json library...

@sashahilton00 commented on GitHub (Feb 1, 2018): i don't believe it does anything in the current version, though @plietar would be the best person to talk to about that. the v0.2 branch was the beginning of a rewrite for librespot, but serde_derive doesn't look to do much, given that Serialize and Deserialize are already in use from the serde_json library...

kerem commented

2026-02-27 19:28:50 +03:00

Author

Owner

@plietar commented on GitHub (Feb 2, 2018):

serde_derive has been working on Rust stable since 1.16. I'm pretty sure the recommendation in the readme is just a left over from a while ago and can be deleted now.

@plietar commented on GitHub (Feb 2, 2018): `serde_derive` has been working on Rust stable since 1.16. I'm pretty sure the recommendation in the readme is just a left over from a while ago and can be deleted now.

kerem commented

2026-02-27 19:28:50 +03:00

Author

Owner

@sashahilton00 commented on GitHub (Feb 2, 2018):

Closing then, as readme has no mention of nightly flag. Reopen if necessary.

@sashahilton00 commented on GitHub (Feb 2, 2018): Closing then, as readme has no mention of nightly flag. Reopen if necessary.

kerem commented

2026-02-27 19:28:50 +03:00

Author

Owner

@ComlOnline commented on GitHub (Feb 2, 2018):

Just for sake of completeness this was in the Dev section of the readme. I moved it to here. I'll remove the bit about the nightly feature.

@ComlOnline commented on GitHub (Feb 2, 2018): Just for sake of completeness this was in the Dev section of the readme. I moved it to [here](https://github.com/librespot-org/librespot/wiki/Development). I'll remove the bit about the nightly feature.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#97

No description provided.

Rows
Columns