[PR #518] [MERGED] Handle cache full situation #957

Closed
opened 2026-02-27 20:00:36 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/518
Author: @LaurentLouf
Created: 8/6/2020
Status: Merged
Merged: 12/13/2020
Merged by: @sashahilton00

Base: devHead: feature-handle_cache_full_situation


📝 Commits (3)

  • f075a75 Disable audio cache when there is an error trying to create a file
  • 9d832ba Instead of disabling audio cache, just clean the audio cache and start caching again from the current file
  • 5f11dde Main issue is probably when copying the content to the file, not during the file creation, but handle both cases just to be sure

📊 Changes

1 file changed (+17 additions, -3 deletions)

View changed files

📝 core/src/cache.rs (+17 -3)

📄 Description

Automatically clean the audio cache when we encounter an error writing some file to the cache. Useful when used on a small target like the Pi or using the RAM as audio cache, which might get full quickly, especially if the Raspberry is always on


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/518 **Author:** [@LaurentLouf](https://github.com/LaurentLouf) **Created:** 8/6/2020 **Status:** ✅ Merged **Merged:** 12/13/2020 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `dev` ← **Head:** `feature-handle_cache_full_situation` --- ### 📝 Commits (3) - [`f075a75`](https://github.com/librespot-org/librespot/commit/f075a75aeedfc88f4c9932d2d8922f3c60371fe9) Disable audio cache when there is an error trying to create a file - [`9d832ba`](https://github.com/librespot-org/librespot/commit/9d832baf83adf653243ac6e0b6de0b12b53b0a37) Instead of disabling audio cache, just clean the audio cache and start caching again from the current file - [`5f11dde`](https://github.com/librespot-org/librespot/commit/5f11ddea50c12ea43b7ab57400c211c7f1f671b2) Main issue is probably when copying the content to the file, not during the file creation, but handle both cases just to be sure ### 📊 Changes **1 file changed** (+17 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `core/src/cache.rs` (+17 -3) </details> ### 📄 Description Automatically clean the audio cache when we encounter an error writing some file to the cache. Useful when used on a small target like the Pi or using the RAM as audio cache, which might get full quickly, especially if the Raspberry is always on --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:00:36 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/librespot#957
No description provided.