[PR #526] [MERGED] Align PLAYER_EVENT naming #955

New issue

Closed

opened 2026-02-27 20:00:36 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/526
Author: @marcelbuesing
Created: 9/25/2020
Status: ✅ Merged
Merged: 2/5/2021
Merged by: @sashahilton00

Base: dev ← Head: align-player-events

📝 Commits (1)

a377463 Align PLAYER_EVENT naming

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 src/player_event_handler.rs (+3 -3)

📄 Description

I'm not sure if this is worth the breaking change, it just turned out be hard to align ENV names in spotifyd. src/process.rs to this as naming was not consistent with the enum names. If there is some changelog I assume it would be good to explicitly mention this as beaking change if it is merged.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/526 **Author:** [@marcelbuesing](https://github.com/marcelbuesing) **Created:** 9/25/2020 **Status:** ✅ Merged **Merged:** 2/5/2021 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `dev` ← **Head:** `align-player-events` --- ### 📝 Commits (1) - [`a377463`](https://github.com/librespot-org/librespot/commit/a3774632a0848eda5cfce89d9a97364eacb8d1b6) Align PLAYER_EVENT naming ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/player_event_handler.rs` (+3 -3) </details> ### 📄 Description I'm not sure if this is worth the breaking change, it just turned out be hard to align ENV names in spotifyd. `src/process.rs` to this as naming was not consistent with the enum names. If there is some changelog I assume it would be good to explicitly mention this as beaking change if it is merged. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:36 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:23 +03:00

[PR #955] [CLOSED] New api #1159

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#955

No description provided.

Rows
Columns