[PR #504] [MERGED] General fixes to protobuf bindings, depreciation warnings and publish.sh #953

New issue

Closed

opened 2026-02-27 20:00:35 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/504
Author: @sashahilton00
Created: 7/24/2020
Status: ✅ Merged
Merged: 7/26/2020
Merged by: @sashahilton00

Base: dev ← Head: build-fixes

📝 Commits (5)

4de9c92 Update build.rs & publish.sh with minor fixes
22ca944 Small tweak to console output during publishing.
4a21b5c Fix depreciation warnings
e97911e Generate proto bindings in OUT_DIR, remove precompiled bindings
16462b3 Accidentally bumped protobuf version

📊 Changes

21 files changed (+95 additions, -43121 deletions)

View changed files

📝 Cargo.lock (+1 -0)
📝 Cargo.toml (+1 -1)
📝 audio/src/lewton_decoder.rs (+0 -4)
📝 connect/src/spirc.rs (+2 -2)
📝 core/src/proxytunnel.rs (+1 -2)
📝 protocol/Cargo.toml (+1 -0)
📝 protocol/build.rs (+64 -54)
➕ protocol/proto/mod.rs (+4 -0)
➖ protocol/src/authentication.rs (+0 -5647)
➖ protocol/src/keyexchange.rs (+0 -7589)
📝 protocol/src/lib.rs (+2 -11)
➖ protocol/src/mercury.rs (+0 -1997)
➖ protocol/src/metadata.rs (+0 -10647)
➖ protocol/src/playlist4changes.rs (+0 -3970)
➖ protocol/src/playlist4content.rs (+0 -1597)
➖ protocol/src/playlist4issues.rs (+0 -794)
➖ protocol/src/playlist4meta.rs (+0 -2240)
➖ protocol/src/playlist4ops.rs (+0 -3742)
➖ protocol/src/pubsub.rs (+0 -320)
➖ protocol/src/spirc.rs (+0 -4503)

...and 1 more files

📄 Description

Should fix the rust docs error mentioned by @ashthespy in Gitter. Also updates the publish script with some minor tweaks to deal with lock file and issues with remote server timing.

Have also fixed the depreciation warnings by removing redundant description methods and changing description() instances to use to_string()

N.B. This is non-functional atm, build.rs/lib.rs needs further updating.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/504 **Author:** [@sashahilton00](https://github.com/sashahilton00) **Created:** 7/24/2020 **Status:** ✅ Merged **Merged:** 7/26/2020 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `dev` ← **Head:** `build-fixes` --- ### 📝 Commits (5) - [`4de9c92`](https://github.com/librespot-org/librespot/commit/4de9c92a29f75e45a6aa30fab92de155fc4c8c10) Update build.rs & publish.sh with minor fixes - [`22ca944`](https://github.com/librespot-org/librespot/commit/22ca944c772600f33fb1eb38ecfd6bf18fd7ccbf) Small tweak to console output during publishing. - [`4a21b5c`](https://github.com/librespot-org/librespot/commit/4a21b5cbeb4ab5749bc8a3e4c8747f4eb1397596) Fix depreciation warnings - [`e97911e`](https://github.com/librespot-org/librespot/commit/e97911e3cfcb85b524e844d0ef5417bbee1e4970) Generate proto bindings in OUT_DIR, remove precompiled bindings - [`16462b3`](https://github.com/librespot-org/librespot/commit/16462b34e20aec595ead124c615d8f0290fbf759) Accidentally bumped protobuf version ### 📊 Changes **21 files changed** (+95 additions, -43121 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+1 -0) 📝 `Cargo.toml` (+1 -1) 📝 `audio/src/lewton_decoder.rs` (+0 -4) 📝 `connect/src/spirc.rs` (+2 -2) 📝 `core/src/proxytunnel.rs` (+1 -2) 📝 `protocol/Cargo.toml` (+1 -0) 📝 `protocol/build.rs` (+64 -54) ➕ `protocol/proto/mod.rs` (+4 -0) ➖ `protocol/src/authentication.rs` (+0 -5647) ➖ `protocol/src/keyexchange.rs` (+0 -7589) 📝 `protocol/src/lib.rs` (+2 -11) ➖ `protocol/src/mercury.rs` (+0 -1997) ➖ `protocol/src/metadata.rs` (+0 -10647) ➖ `protocol/src/playlist4changes.rs` (+0 -3970) ➖ `protocol/src/playlist4content.rs` (+0 -1597) ➖ `protocol/src/playlist4issues.rs` (+0 -794) ➖ `protocol/src/playlist4meta.rs` (+0 -2240) ➖ `protocol/src/playlist4ops.rs` (+0 -3742) ➖ `protocol/src/pubsub.rs` (+0 -320) ➖ `protocol/src/spirc.rs` (+0 -4503) _...and 1 more files_ </details> ### 📄 Description Should fix the rust docs error mentioned by @ashthespy in Gitter. Also updates the publish script with some minor tweaks to deal with lock file and issues with remote server timing. Have also fixed the depreciation warnings by removing redundant description methods and changing `description()` instances to use `to_string()` N.B. This is non-functional atm, build.rs/lib.rs needs further updating. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:35 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#953

No description provided.

Rows
Columns