[PR #485] [MERGED] Bump protobuf v2.8.1 -> v~2.14.0 and fix build issues #946

Closed
opened 2026-02-27 20:00:34 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/485
Author: @ashthespy
Created: 5/28/2020
Status: Merged
Merged: 7/22/2020
Merged by: @ashthespy

Base: devHead: fix_protobuf


📝 Commits (1)

  • 76ece26 Bump protobuf v2.8.1 -> v~2.14.0 and fix build issues

📊 Changes

18 files changed (+764 additions, -1561 deletions)

View changed files

📝 Cargo.lock (+16 -16)
📝 Cargo.toml (+1 -1)
📝 connect/Cargo.toml (+1 -1)
📝 core/Cargo.toml (+1 -1)
📝 metadata/Cargo.toml (+1 -1)
📝 protocol/Cargo.toml (+3 -3)
📝 protocol/build.rs (+7 -6)
📝 protocol/src/authentication.rs (+108 -225)
📝 protocol/src/keyexchange.rs (+167 -353)
📝 protocol/src/mercury.rs (+38 -80)
📝 protocol/src/metadata.rs (+150 -312)
📝 protocol/src/playlist4changes.rs (+53 -113)
📝 protocol/src/playlist4content.rs (+24 -51)
📝 protocol/src/playlist4issues.rs (+30 -57)
📝 protocol/src/playlist4meta.rs (+38 -80)
📝 protocol/src/playlist4ops.rs (+61 -127)
📝 protocol/src/pubsub.rs (+9 -18)
📝 protocol/src/spirc.rs (+56 -116)

📄 Description

A housekeeping follow up to https://github.com/librespot-org/librespot/pull/463

We probably should push this as a patch fix to master https://github.com/librespot-org/librespot/issues/477


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/485 **Author:** [@ashthespy](https://github.com/ashthespy) **Created:** 5/28/2020 **Status:** ✅ Merged **Merged:** 7/22/2020 **Merged by:** [@ashthespy](https://github.com/ashthespy) **Base:** `dev` ← **Head:** `fix_protobuf` --- ### 📝 Commits (1) - [`76ece26`](https://github.com/librespot-org/librespot/commit/76ece26aa4d5a21132393264302c84765fa4998e) Bump protobuf v2.8.1 -> v~2.14.0 and fix build issues ### 📊 Changes **18 files changed** (+764 additions, -1561 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+16 -16) 📝 `Cargo.toml` (+1 -1) 📝 `connect/Cargo.toml` (+1 -1) 📝 `core/Cargo.toml` (+1 -1) 📝 `metadata/Cargo.toml` (+1 -1) 📝 `protocol/Cargo.toml` (+3 -3) 📝 `protocol/build.rs` (+7 -6) 📝 `protocol/src/authentication.rs` (+108 -225) 📝 `protocol/src/keyexchange.rs` (+167 -353) 📝 `protocol/src/mercury.rs` (+38 -80) 📝 `protocol/src/metadata.rs` (+150 -312) 📝 `protocol/src/playlist4changes.rs` (+53 -113) 📝 `protocol/src/playlist4content.rs` (+24 -51) 📝 `protocol/src/playlist4issues.rs` (+30 -57) 📝 `protocol/src/playlist4meta.rs` (+38 -80) 📝 `protocol/src/playlist4ops.rs` (+61 -127) 📝 `protocol/src/pubsub.rs` (+9 -18) 📝 `protocol/src/spirc.rs` (+56 -116) </details> ### 📄 Description A housekeeping follow up to https://github.com/librespot-org/librespot/pull/463 We probably should push this as a patch fix to master https://github.com/librespot-org/librespot/issues/477 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:00:34 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/librespot#946
No description provided.