[PR #474] [MERGED] Skip unplayable tracks instead of stopping #941

New issue

Closed

opened 2026-02-27 20:00:32 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/474
Author: @ashthespy
Created: 5/9/2020
Status: ✅ Merged
Merged: 7/24/2020
Merged by: @sashahilton00

Base: dev ← Head: skip_unplayable

📝 Commits (9)

b631997 Skip unplayable tracks instead of stopping
9024409 Handle unplayable tracks during prefetch
14709b9 Let spirc handle unavailable tracks
172cb94 Merge branch 'dev' of https://github.com/librespot-org/librespot into skip_unplayable
9cacc2d Fix regression in track cycling
01813cf Tweak unavailable track handling
1da80ce Handle unplayable track at start of playlist
a28199f Tweak handling unavailables at start of playlists
16112d7 Search through full playlist for unplayable tracks

📊 Changes

2 files changed (+163 additions, -32 deletions)

View changed files

📝 connect/src/spirc.rs (+81 -29)
📝 playback/src/player.rs (+82 -3)

📄 Description

Restoring the previous behaviour of skipping unplayable tracks.
Not tested the case when a unplayable track is at the end of a playlist though..

Yeah, sorry; here's one example:

https://open.spotify.com/playlist/4HrLayxlfZuW8YNwuK1g41?si=6_9XTofvTSW1ry4IY-95eg

spotify:playlist:4HrLayxlfZuW8YNwuK1g41

Originally posted by @pachulo in https://github.com/balbuze/volumio-plugins/issues/266#issuecomment-622396906

@kaymes Do you see any issues?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/474 **Author:** [@ashthespy](https://github.com/ashthespy) **Created:** 5/9/2020 **Status:** ✅ Merged **Merged:** 7/24/2020 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `dev` ← **Head:** `skip_unplayable` --- ### 📝 Commits (9) - [`b631997`](https://github.com/librespot-org/librespot/commit/b63199743aef01868a67be451e6d46a288264235) Skip unplayable tracks instead of stopping - [`9024409`](https://github.com/librespot-org/librespot/commit/902440925d2c4b334d7b72fe64b198ef377692f8) Handle unplayable tracks during prefetch - [`14709b9`](https://github.com/librespot-org/librespot/commit/14709b9f8deeba75f7de808dc3421f962a1a49c9) Let spirc handle unavailable tracks - [`172cb94`](https://github.com/librespot-org/librespot/commit/172cb945c459704303aa01919520a9a7288d7c87) Merge branch 'dev' of https://github.com/librespot-org/librespot into skip_unplayable - [`9cacc2d`](https://github.com/librespot-org/librespot/commit/9cacc2d09fd08bb132a250df51d1f77f9315f15f) Fix regression in track cycling - [`01813cf`](https://github.com/librespot-org/librespot/commit/01813cf7c95c8e75b5fce39f6d99d22ca2f8fef2) Tweak unavailable track handling - [`1da80ce`](https://github.com/librespot-org/librespot/commit/1da80ce480a4e398c2e0c6bd896da6f1da38835e) Handle unplayable track at start of playlist - [`a28199f`](https://github.com/librespot-org/librespot/commit/a28199f07341f3437cb8d6959c6c3f79f11b4a51) Tweak handling unavailables at start of playlists - [`16112d7`](https://github.com/librespot-org/librespot/commit/16112d71b968d3de4e45554f075970cf91ada39d) Search through full playlist for unplayable tracks ### 📊 Changes **2 files changed** (+163 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `connect/src/spirc.rs` (+81 -29) 📝 `playback/src/player.rs` (+82 -3) </details> ### 📄 Description Restoring the previous behaviour of skipping unplayable tracks. Not tested the case when a unplayable track is at the end of a playlist though.. > >Yeah, sorry; here's one example: >- https://open.spotify.com/playlist/4HrLayxlfZuW8YNwuK1g41?si=6_9XTofvTSW1ry4IY-95eg >- spotify:playlist:4HrLayxlfZuW8YNwuK1g41 > >_Originally posted by @pachulo in https://github.com/balbuze/volumio-plugins/issues/266#issuecomment-622396906_ @kaymes Do you see any issues? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:32 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#941

No description provided.

Rows
Columns