[PR #447] [MERGED] Refactor Volume control, allow for a fixed volume option #931

New issue

Closed

opened 2026-02-27 20:00:30 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/447
Author: @ashthespy
Created: 3/9/2020
Status: ✅ Merged
Merged: 7/25/2020
Merged by: @ashthespy

Base: dev ← Head: volume

📝 Commits (1)

8541065 Refactor Volume control, allow for a fixed volume option

📊 Changes

3 files changed (+58 additions, -19 deletions)

View changed files

📝 connect/src/spirc.rs (+19 -13)
📝 core/src/config.rs (+27 -1)
📝 src/main.rs (+12 -5)

📄 Description

This is a (long) overdue follow up to https://github.com/librespot-org/librespot/pull/286#issuecomment-509263437.

I have refactored the old --linear-volume flag to a more generic --volume-ctrl option that takes the options of [linear, log, fixed]. It defaults as previously to log.

What fixed does is disable the client side volume control, by setting kVolumeSteps to 0, so no volume events are passed to the client.

As usual, this will need a update of the wiki, and should be considered a "breaking change" when considering the versioning.

Fixes #48, Closes #286

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/447 **Author:** [@ashthespy](https://github.com/ashthespy) **Created:** 3/9/2020 **Status:** ✅ Merged **Merged:** 7/25/2020 **Merged by:** [@ashthespy](https://github.com/ashthespy) **Base:** `dev` ← **Head:** `volume` --- ### 📝 Commits (1) - [`8541065`](https://github.com/librespot-org/librespot/commit/85410655a84a26c68f83e2a6c5c75164c1e6a1a7) Refactor Volume control, allow for a fixed volume option ### 📊 Changes **3 files changed** (+58 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `connect/src/spirc.rs` (+19 -13) 📝 `core/src/config.rs` (+27 -1) 📝 `src/main.rs` (+12 -5) </details> ### 📄 Description This is a (long) overdue follow up to https://github.com/librespot-org/librespot/pull/286#issuecomment-509263437. I have refactored the old `--linear-volume` flag to a more generic `--volume-ctrl` option that takes the options of `[linear, log, fixed]`. It defaults as previously to `log`. What `fixed` does is disable the client side volume control, by setting `kVolumeSteps` to 0, so no volume events are passed to the client. ![image](https://user-images.githubusercontent.com/16233271/76242952-cff6c200-6237-11ea-80e4-9cf1145bde46.png) As usual, this will need a update of the wiki, and should be considered a "breaking change" when considering the versioning. Fixes #48, Closes #286 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:30 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#931

No description provided.

Rows
Columns