mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[PR #443] [MERGED] [alsa] Implement cubic mapping for hardware mixers #928
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#928
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/librespot-org/librespot/pull/443
Author: @ashthespy
Created: 3/4/2020
Status: ✅ Merged
Merged: 7/29/2020
Merged by: @sashahilton00
Base:
dev← Head:maped_mixer📝 Commits (4)
3dfad7fImplement mapped volume for alsa mixer527a4ccBetteralsamixervolume mapping for hardware mixers4632881Makealsamixerless verbose9e7180fUse mixer's mute switch if possible📊 Changes
3 files changed (+171 additions, -23 deletions)
View changed files
📝
playback/src/mixer/alsamixer.rs(+163 -23)📝
playback/src/mixer/mod.rs(+2 -0)📝
src/main.rs(+6 -0)📄 Description
This implements a cubic mapping for hardware mixers similar to
alsamixerCherry picked from my old branch and did some housekeeping. It should work, but don't have access to a device with a hardware mixer currently to test.
Volunteers? @JPW21
Fixes #433
Note
This introduces a level of confusion as
--linear-volumeis how we map the request volume Spotify to our client. This value is then mapped cubically to the hardware mixer by default (similar toalsamixerandamixer -m), and can be overridden with themixer-linear-volumeflag.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.