[PR #444] [MERGED] Disable gapless playback via runtime flag #927

New issue

Closed

opened 2026-02-27 20:00:29 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/444
Author: @ashthespy
Created: 3/4/2020
Status: ✅ Merged
Merged: 3/10/2020
Merged by: @ashthespy

Base: dev ← Head: gapless_patch

📝 Commits (3)

2935544 Enable gapless playback via runtime flag
217ef88 Set gapless playback as default, use --disable-gapless to turn it off
6557055 Ensure sink restarts b/w tracks when gapless is disabled

📊 Changes

3 files changed (+11 additions, -1 deletions)

View changed files

📝 playback/src/config.rs (+2 -0)
📝 playback/src/player.rs (+3 -0)
📝 src/main.rs (+6 -1)

📄 Description

Follow up to the work in #430, added a runtime flag for the feature.

@kaymes I didn't look at your implementation in detail - but from a quick glance this should suffice or will the sink continue to remain open?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/444 **Author:** [@ashthespy](https://github.com/ashthespy) **Created:** 3/4/2020 **Status:** ✅ Merged **Merged:** 3/10/2020 **Merged by:** [@ashthespy](https://github.com/ashthespy) **Base:** `dev` ← **Head:** `gapless_patch` --- ### 📝 Commits (3) - [`2935544`](https://github.com/librespot-org/librespot/commit/2935544be86c479a223f87d7a42ca22f0fe61d63) Enable gapless playback via runtime flag - [`217ef88`](https://github.com/librespot-org/librespot/commit/217ef88997999860435d5641ce830e2c4f948241) Set gapless playback as default, use `--disable-gapless` to turn it off - [`6557055`](https://github.com/librespot-org/librespot/commit/6557055f319e2cda370df543619d7b858aec0b5a) Ensure sink restarts b/w tracks when gapless is disabled ### 📊 Changes **3 files changed** (+11 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `playback/src/config.rs` (+2 -0) 📝 `playback/src/player.rs` (+3 -0) 📝 `src/main.rs` (+6 -1) </details> ### 📄 Description Follow up to the work in #430, added a runtime flag for the feature. @kaymes I didn't look at your implementation in detail - but from a [quick glance](https://github.com/ashthespy/librespot/blob/2935544be86c479a223f87d7a42ca22f0fe61d63/playback/src/player.rs#L1229-L1231) this should suffice or will the sink continue to remain open? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:29 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#927

No description provided.

Rows
Columns