[PR #423] [MERGED] Migrate to rust 2018 edition #917

New issue

Closed

opened 2026-02-27 20:00:27 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/423
Author: @marcelbuesing
Created: 1/17/2020
Status: ✅ Merged
Merged: 1/24/2020
Merged by: @sashahilton00

Base: dev ← Head: rust-2018

📝 Commits (4)

be2ad90 Migrate to rust 2018 edition
d26590a Update to Rust 2018
38d82f2 Rerun rustfmt on full codebase
c9147d3 Turn child crates into rust 2018 edition

📊 Changes

55 files changed (+448 additions, -324 deletions)

View changed files

📝 .travis.yml (+2 -0)
📝 Cargo.toml (+1 -0)
📝 audio/Cargo.toml (+1 -0)
📝 audio/src/decrypt.rs (+5 -8)
📝 audio/src/fetch.rs (+43 -19)
📝 audio/src/lib.rs (+1 -1)
📝 audio/src/libvorbis_decoder.rs (+2 -2)
📝 audio/src/range_set.rs (+13 -4)
📝 connect/Cargo.toml (+1 -0)
📝 connect/src/context.rs (+2 -2)
📝 connect/src/discovery.rs (+28 -27)
📝 connect/src/lib.rs (+2 -2)
📝 connect/src/spirc.rs (+44 -22)
📝 core/Cargo.toml (+1 -0)
📝 core/src/apresolve.rs (+10 -9)
📝 core/src/audio_key.rs (+7 -3)
📝 core/src/authentication.rs (+16 -15)
📝 core/src/cache.rs (+4 -4)
📝 core/src/channel.rs (+1 -1)
📝 core/src/config.rs (+1 -1)

...and 35 more files

📄 Description

Migrated to rust 2018 edition using cargo fix and removed extern crate as this is redundant in Rust 2018. For more details about the transition here.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/423 **Author:** [@marcelbuesing](https://github.com/marcelbuesing) **Created:** 1/17/2020 **Status:** ✅ Merged **Merged:** 1/24/2020 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `dev` ← **Head:** `rust-2018` --- ### 📝 Commits (4) - [`be2ad90`](https://github.com/librespot-org/librespot/commit/be2ad9059a47135768259454b7659984c6c28894) Migrate to rust 2018 edition - [`d26590a`](https://github.com/librespot-org/librespot/commit/d26590afc536128d22ef560a842aef87964a2d20) Update to Rust 2018 - [`38d82f2`](https://github.com/librespot-org/librespot/commit/38d82f2dc26d15c17f97585f68ce3575bac5c503) Rerun rustfmt on full codebase - [`c9147d3`](https://github.com/librespot-org/librespot/commit/c9147d31ab47d8daf989d2450465d7f8ee4ef965) Turn child crates into rust 2018 edition ### 📊 Changes **55 files changed** (+448 additions, -324 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+2 -0) 📝 `Cargo.toml` (+1 -0) 📝 `audio/Cargo.toml` (+1 -0) 📝 `audio/src/decrypt.rs` (+5 -8) 📝 `audio/src/fetch.rs` (+43 -19) 📝 `audio/src/lib.rs` (+1 -1) 📝 `audio/src/libvorbis_decoder.rs` (+2 -2) 📝 `audio/src/range_set.rs` (+13 -4) 📝 `connect/Cargo.toml` (+1 -0) 📝 `connect/src/context.rs` (+2 -2) 📝 `connect/src/discovery.rs` (+28 -27) 📝 `connect/src/lib.rs` (+2 -2) 📝 `connect/src/spirc.rs` (+44 -22) 📝 `core/Cargo.toml` (+1 -0) 📝 `core/src/apresolve.rs` (+10 -9) 📝 `core/src/audio_key.rs` (+7 -3) 📝 `core/src/authentication.rs` (+16 -15) 📝 `core/src/cache.rs` (+4 -4) 📝 `core/src/channel.rs` (+1 -1) 📝 `core/src/config.rs` (+1 -1) _...and 35 more files_ </details> ### 📄 Description Migrated to rust 2018 edition using `cargo fix` and removed `extern crate` as this is redundant in Rust 2018. For more details about the transition [here](https://doc.rust-lang.org/edition-guide/editions/transitioning-an-existing-project-to-a-new-edition.html). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:27 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#917

No description provided.

Rows
Columns