[PR #383] [MERGED] Lock Rodio to v0.9 #902

New issue

Closed

opened 2026-02-27 20:00:23 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/383
Author: @andrewburgess
Created: 10/9/2019
Status: ✅ Merged
Merged: 10/9/2019
Merged by: @ashthespy

Base: master ← Head: master

📝 Commits (1)

5937e4f 📌 fix: lock rodio to v0.9

📊 Changes

2 files changed (+4 additions, -4 deletions)

View changed files

📝 Cargo.lock (+3 -3)
📝 playback/Cargo.toml (+1 -1)

📄 Description

rodio pushed a change (github.com/RustAudio/rodio@0151398043) to, updating the dependency cpal to v0.10, which is incompatible with the current librespot implementation.

This wouldn't be noticeable when working with librespot directly based on how Cargo resolves dependencies (I think, still figuring this whole Rust thing out), but if librespot is being used as a dependency in another project, then the newer cpal crate also gets pulled in, and librespot won't compile.

The change in rodio has only occurred in the repository, there hasn't been a new version published, so I figured it would be better to pin the dependency version for the time being.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/383 **Author:** [@andrewburgess](https://github.com/andrewburgess) **Created:** 10/9/2019 **Status:** ✅ Merged **Merged:** 10/9/2019 **Merged by:** [@ashthespy](https://github.com/ashthespy) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`5937e4f`](https://github.com/librespot-org/librespot/commit/5937e4fb6e0caa3b7641e27bef2775bd997003d4) :pushpin: fix: lock rodio to v0.9 ### 📊 Changes **2 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+3 -3) 📝 `playback/Cargo.toml` (+1 -1) </details> ### 📄 Description `rodio` pushed a change (https://github.com/RustAudio/rodio/commit/0151398043a07e0b44583f03e77ad8ab935c3dbc) to, updating the dependency `cpal` to `v0.10`, which is incompatible with the current `librespot` implementation. This wouldn't be noticeable when working with `librespot` directly based on how Cargo resolves dependencies (I think, still figuring this whole Rust thing out), but if `librespot` is being used as a dependency in another project, then the newer `cpal` crate also gets pulled in, and `librespot` won't compile. The change in `rodio` has only occurred in the repository, there hasn't been a new version published, so I figured it would be better to pin the dependency version for the time being. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:23 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:18 +03:00

[PR #905] [MERGED] Skip track on decoding error #1138

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#902

No description provided.

Rows
Columns