[PR #386] [MERGED] Ignore false shuffle/repeat when changing contexts to match Android behaviour (fixes: #266) #900

New issue

Closed

opened 2026-02-27 20:00:23 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/386
Author: @willstott101
Created: 10/19/2019
Status: ✅ Merged
Merged: 2/13/2020
Merged by: @sashahilton00

Base: dev ← Head: cha_cha_shuffle

📝 Commits (1)

8b80326 Fix shuffle and repeat when changing contexts to match Android behaviour

📊 Changes

1 file changed (+10 additions, -2 deletions)

View changed files

📝 connect/src/spirc.rs (+10 -2)

📄 Description

Seems strange that these fields return true in the has_ methods when as far as I can tell it's impossible to remove the shuffle/repeat state in the client without explicitly toggling them with their dedicated buttons.

@devgianlu You mention in #266 that that librespot-java might handle this better, (I couldn't get it to work with Zeroconf on my windows laptop, I'll try again later), but browsing the code I couldn't see anything like this so I'm curious if the shuffle state does actually work better over there? Perhaps you've found a better solution.

EDIT: It would be great if a few people could try this out and see if they can get inconsistent behaviour between an official client and Librespot with these changes.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/386 **Author:** [@willstott101](https://github.com/willstott101) **Created:** 10/19/2019 **Status:** ✅ Merged **Merged:** 2/13/2020 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `dev` ← **Head:** `cha_cha_shuffle` --- ### 📝 Commits (1) - [`8b80326`](https://github.com/librespot-org/librespot/commit/8b8032634a7a478020c7253def63f3ba18aa794e) Fix shuffle and repeat when changing contexts to match Android behaviour ### 📊 Changes **1 file changed** (+10 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `connect/src/spirc.rs` (+10 -2) </details> ### 📄 Description Seems strange that these fields return true in the has_ methods when as far as I can tell it's impossible to remove the shuffle/repeat state in the client without explicitly toggling them with their dedicated buttons. @devgianlu You mention in #266 that that librespot-java might handle this better, (I couldn't get it to work with Zeroconf on my windows laptop, I'll try again later), but [browsing the code](https://github.com/librespot-org/librespot-java/blob/0a08ba32eb8036f96a65f1cc57e1ea155da52ff1/core/src/main/java/xyz/gianlu/librespot/player/StateWrapper.java#L251) I couldn't see anything like this so I'm curious if the shuffle state does actually work better over there? Perhaps you've found a better solution. EDIT: It would be great if a few people could try this out and see if they can get inconsistent behaviour between an official client and Librespot with these changes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:23 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#900

No description provided.

Rows
Columns