[PR #377] [CLOSED] Improved podcast support #895

Closed
opened 2026-02-27 20:00:22 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/377
Author: @StopMotionCuber
Created: 10/3/2019
Status: Closed

Base: devHead: improved_podcast_support


📝 Commits (10+)

  • 1ef9d79 added audio/episode to supported capabilities
  • 6fc8f4e added method in spotify id to extract id from uri
  • 6ac9988 added episode bool to session
  • db99a8e bugfix in spotifyid from uri
  • fa0b5d9 added episode struct and parsing
  • 4d08234 real ugly now:
  • 063d043 small bugfix. change isEpisode back when song is played
  • 430a0a6 bugfix: podcast uri can start with spotify:episode
  • 38fada6 Cleanup on podcast support
  • 5d4325a Merge branch 'real_master' into improved_podcast_support

📊 Changes

5 files changed (+137 additions, -40 deletions)

View changed files

📝 connect/src/spirc.rs (+21 -11)
📝 core/src/spotify_id.rs (+58 -9)
📝 examples/play.rs (+1 -1)
📝 metadata/src/lib.rs (+28 -2)
📝 playback/src/player.rs (+29 -17)

📄 Description

I did some work on PR #339 and did some improvements that were suggested there.
This is my first work with rust, so I hope that my code is not too ugly.
If you have any concerns (or find leftover debug messages), feel free to hit me up.

I'd love to finally have Podcast support for my Pi on upstream


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/377 **Author:** [@StopMotionCuber](https://github.com/StopMotionCuber) **Created:** 10/3/2019 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `improved_podcast_support` --- ### 📝 Commits (10+) - [`1ef9d79`](https://github.com/librespot-org/librespot/commit/1ef9d7976a3c06c774fa794de95013e6947b3c1c) added audio/episode to supported capabilities - [`6fc8f4e`](https://github.com/librespot-org/librespot/commit/6fc8f4e6035cbcf2210bf1b8acc5ac397cba685a) added method in spotify id to extract id from uri - [`6ac9988`](https://github.com/librespot-org/librespot/commit/6ac99882468bc13e6f404d2eaf4ee3834c9a9d34) added episode bool to session - [`db99a8e`](https://github.com/librespot-org/librespot/commit/db99a8ea752da4c00d82115371bf4d36e29597da) bugfix in spotifyid from uri - [`fa0b5d9`](https://github.com/librespot-org/librespot/commit/fa0b5d92c410498262a6dffc2f27ac4933a8d063) added episode struct and parsing - [`4d08234`](https://github.com/librespot-org/librespot/commit/4d082349a826fb19bfac8a920b76c215e6ff612a) real ugly now: - [`063d043`](https://github.com/librespot-org/librespot/commit/063d043a7b2db3a317b26f5b60570e0d5b3f1cc4) small bugfix. change isEpisode back when song is played - [`430a0a6`](https://github.com/librespot-org/librespot/commit/430a0a685f11a6b93d0d789f1bf481263aad3aa8) bugfix: podcast uri can start with spotify:episode - [`38fada6`](https://github.com/librespot-org/librespot/commit/38fada647bb7e6c3da035a26207ee2c77dd0d284) Cleanup on podcast support - [`5d4325a`](https://github.com/librespot-org/librespot/commit/5d4325a01f0e0f94093b0fdc65d16bfc306dd63a) Merge branch 'real_master' into improved_podcast_support ### 📊 Changes **5 files changed** (+137 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `connect/src/spirc.rs` (+21 -11) 📝 `core/src/spotify_id.rs` (+58 -9) 📝 `examples/play.rs` (+1 -1) 📝 `metadata/src/lib.rs` (+28 -2) 📝 `playback/src/player.rs` (+29 -17) </details> ### 📄 Description I did some work on PR #339 and did some improvements that were suggested there. This is my first work with rust, so I hope that my code is not too ugly. If you have any concerns (or find leftover debug messages), feel free to hit me up. I'd love to finally have Podcast support for my Pi on upstream --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:00:22 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/librespot#895
No description provided.