mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[PR #377] [CLOSED] Improved podcast support #895
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#895
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/librespot-org/librespot/pull/377
Author: @StopMotionCuber
Created: 10/3/2019
Status: ❌ Closed
Base:
dev← Head:improved_podcast_support📝 Commits (10+)
1ef9d79added audio/episode to supported capabilities6fc8f4eadded method in spotify id to extract id from uri6ac9988added episode bool to sessiondb99a8ebugfix in spotifyid from urifa0b5d9added episode struct and parsing4d08234real ugly now:063d043small bugfix. change isEpisode back when song is played430a0a6bugfix: podcast uri can start with spotify:episode38fada6Cleanup on podcast support5d4325aMerge branch 'real_master' into improved_podcast_support📊 Changes
5 files changed (+137 additions, -40 deletions)
View changed files
📝
connect/src/spirc.rs(+21 -11)📝
core/src/spotify_id.rs(+58 -9)📝
examples/play.rs(+1 -1)📝
metadata/src/lib.rs(+28 -2)📝
playback/src/player.rs(+29 -17)📄 Description
I did some work on PR #339 and did some improvements that were suggested there.
This is my first work with rust, so I hope that my code is not too ugly.
If you have any concerns (or find leftover debug messages), feel free to hit me up.
I'd love to finally have Podcast support for my Pi on upstream
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.