[PR #366] [CLOSED] Fix nightly #891

New issue

Closed

opened 2026-02-27 20:00:21 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/366
Author: @HEnquist
Created: 8/29/2019
Status: ❌ Closed

Base: master ← Head: fixnightly

📝 Commits (10+)

2688247 Add basic support for playlists
95cd3e1 Fix checskums in protocol files list
5ba86f0 Use new hm endpoint for playlists
8c4dbd4 Remove unused code from example
01b862c Remove unused code from metadata lib
7226fa4 Make standard metadata get handle also playlists
a56f581 Clean up playlist example
7242328 Some more cleaning
ddfe938 Remove forgotten println
8e626b0 Add basic support for playlists

📊 Changes

23 files changed (+11424 additions, -46 deletions)

View changed files

📝 audio/src/decrypt.rs (+1 -1)
📝 audio/src/fetch.rs (+3 -3)
📝 audio/src/lib.rs (+1 -1)
📝 connect/src/context.rs (+1 -1)
📝 connect/src/discovery.rs (+4 -4)
📝 connect/src/lib.rs (+1 -1)
📝 connect/src/spirc.rs (+7 -7)
📝 examples/play.rs (+4 -4)
➕ examples/playlist_tracks.rs (+49 -0)
📝 metadata/src/cover.rs (+3 -3)
📝 metadata/src/lib.rs (+49 -12)
📝 playback/src/lib.rs (+1 -1)
📝 playback/src/player.rs (+2 -2)
📝 protocol/files.rs (+5 -0)
📝 protocol/proto/playlist4changes.proto (+1 -0)
📝 protocol/src/lib.rs (+5 -0)
➕ protocol/src/playlist4changes.rs (+3618 -0)
➕ protocol/src/playlist4content.rs (+1457 -0)
➕ protocol/src/playlist4issues.rs (+761 -0)
➕ protocol/src/playlist4meta.rs (+2074 -0)

...and 3 more files

📄 Description

The nightly build is failing because librespot overwrites the "core" crate. This PR fixes this by removing this alias and just using the full name "librespot_core".
It also includes the changes in https://github.com/librespot-org/librespot/pull/361 and should probably not be merged before that one.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/366 **Author:** [@HEnquist](https://github.com/HEnquist) **Created:** 8/29/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fixnightly` --- ### 📝 Commits (10+) - [`2688247`](https://github.com/librespot-org/librespot/commit/268824748af4d5fa3837a92982fe22bfbe3a1b47) Add basic support for playlists - [`95cd3e1`](https://github.com/librespot-org/librespot/commit/95cd3e15d32f78359f8c8c843ed9312f3ec7dd9e) Fix checskums in protocol files list - [`5ba86f0`](https://github.com/librespot-org/librespot/commit/5ba86f0daa7e6cd22fa07bb234d44758f4d73d11) Use new hm endpoint for playlists - [`8c4dbd4`](https://github.com/librespot-org/librespot/commit/8c4dbd4d6ff91472fbd79a35ec957ab5f67758a1) Remove unused code from example - [`01b862c`](https://github.com/librespot-org/librespot/commit/01b862cb204094e448c8aebd6b56467149d4df06) Remove unused code from metadata lib - [`7226fa4`](https://github.com/librespot-org/librespot/commit/7226fa47baf4d608aac73c318bd88cd52acba0a4) Make standard metadata get handle also playlists - [`a56f581`](https://github.com/librespot-org/librespot/commit/a56f58168d7a905a6a8b8281a86b5d6c45319231) Clean up playlist example - [`7242328`](https://github.com/librespot-org/librespot/commit/7242328ad537841f724b6f13b1c9c245f068780d) Some more cleaning - [`ddfe938`](https://github.com/librespot-org/librespot/commit/ddfe938771ede4dd64699e0e01e0565b020be4e7) Remove forgotten println - [`8e626b0`](https://github.com/librespot-org/librespot/commit/8e626b0a2fdfbca7b7c5f1a2429002122c2252a6) Add basic support for playlists ### 📊 Changes **23 files changed** (+11424 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `audio/src/decrypt.rs` (+1 -1) 📝 `audio/src/fetch.rs` (+3 -3) 📝 `audio/src/lib.rs` (+1 -1) 📝 `connect/src/context.rs` (+1 -1) 📝 `connect/src/discovery.rs` (+4 -4) 📝 `connect/src/lib.rs` (+1 -1) 📝 `connect/src/spirc.rs` (+7 -7) 📝 `examples/play.rs` (+4 -4) ➕ `examples/playlist_tracks.rs` (+49 -0) 📝 `metadata/src/cover.rs` (+3 -3) 📝 `metadata/src/lib.rs` (+49 -12) 📝 `playback/src/lib.rs` (+1 -1) 📝 `playback/src/player.rs` (+2 -2) 📝 `protocol/files.rs` (+5 -0) 📝 `protocol/proto/playlist4changes.proto` (+1 -0) 📝 `protocol/src/lib.rs` (+5 -0) ➕ `protocol/src/playlist4changes.rs` (+3618 -0) ➕ `protocol/src/playlist4content.rs` (+1457 -0) ➕ `protocol/src/playlist4issues.rs` (+761 -0) ➕ `protocol/src/playlist4meta.rs` (+2074 -0) _...and 3 more files_ </details> ### 📄 Description The nightly build is failing because librespot overwrites the "core" crate. This PR fixes this by removing this alias and just using the full name "librespot_core". It also includes the changes in https://github.com/librespot-org/librespot/pull/361 and should probably not be merged before that one. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:21 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:17 +03:00

[PR #891] [MERGED] WIP: new Spotify API #1134

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#891

No description provided.

Rows
Columns