[PR #352] [CLOSED] Rustfmt #885

New issue

Closed

opened 2026-02-27 20:00:19 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/352
Author: @ashthespy
Created: 7/16/2019
Status: ❌ Closed

Base: dev ← Head: rustfmt

📝 Commits (3)

1f7ad99 Update rustfmt.toml and add checks to travis
2e9e793 [rustfmt] Format entire codebase
11e92a3 [ci skip] Update Readme and Contributing to be more consistent

📊 Changes

26 files changed (+127 additions, -132 deletions)

View changed files

📝 .travis.yml (+2 -0)
📝 CONTRIBUTING.md (+14 -39)
📝 README.md (+19 -5)
📝 audio/src/decrypt.rs (+3 -6)
📝 audio/src/fetch.rs (+1 -1)
📝 audio/src/lib.rs (+1 -1)
📝 connect/src/discovery.rs (+25 -25)
📝 connect/src/lib.rs (+2 -2)
📝 core/build.rs (+5 -2)
📝 core/src/apresolve.rs (+1 -1)
📝 core/src/authentication.rs (+4 -4)
📝 core/src/connection/handshake.rs (+4 -6)
📝 core/src/connection/mod.rs (+1 -1)
📝 core/src/lib.rs (+4 -4)
📝 core/src/mercury/types.rs (+2 -1)
📝 core/src/proxytunnel.rs (+2 -1)
📝 core/src/session.rs (+4 -3)
📝 playback/src/audio_backend/alsa.rs (+2 -1)
📝 playback/src/audio_backend/portaudio.rs (+4 -2)
📝 playback/src/audio_backend/rodio.rs (+9 -8)

...and 6 more files

📄 Description

rustfmt is seems to be much more stable than when it was removed back in https://github.com/librespot-org/librespot/issues/208

This PR:

Removes deprecated reorder_imports_in_group as it's now combined with reorder_imports
Add rustfmt checks to Travis (only for stable)
Format the entire codebase (with rustfmt 1.2.2-stable)
Update Contributing.md (and Readme.md while I was at it)
- I also removed removed nightly requirement for development - as rustfmt is available on the stable channel. Or was there other reasons for the nightly requirement?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/352 **Author:** [@ashthespy](https://github.com/ashthespy) **Created:** 7/16/2019 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `rustfmt` --- ### 📝 Commits (3) - [`1f7ad99`](https://github.com/librespot-org/librespot/commit/1f7ad99ee5582deef58014db1b80f4210d3383cc) Update `rustfmt.toml` and add checks to travis - [`2e9e793`](https://github.com/librespot-org/librespot/commit/2e9e7935e978e55e0a56e4a51dad803a675825e9) [rustfmt] Format entire codebase - [`11e92a3`](https://github.com/librespot-org/librespot/commit/11e92a3df9b58490cd6057866d1adaed9a2e6d2f) [ci skip] Update Readme and Contributing to be more consistent ### 📊 Changes **26 files changed** (+127 additions, -132 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+2 -0) 📝 `CONTRIBUTING.md` (+14 -39) 📝 `README.md` (+19 -5) 📝 `audio/src/decrypt.rs` (+3 -6) 📝 `audio/src/fetch.rs` (+1 -1) 📝 `audio/src/lib.rs` (+1 -1) 📝 `connect/src/discovery.rs` (+25 -25) 📝 `connect/src/lib.rs` (+2 -2) 📝 `core/build.rs` (+5 -2) 📝 `core/src/apresolve.rs` (+1 -1) 📝 `core/src/authentication.rs` (+4 -4) 📝 `core/src/connection/handshake.rs` (+4 -6) 📝 `core/src/connection/mod.rs` (+1 -1) 📝 `core/src/lib.rs` (+4 -4) 📝 `core/src/mercury/types.rs` (+2 -1) 📝 `core/src/proxytunnel.rs` (+2 -1) 📝 `core/src/session.rs` (+4 -3) 📝 `playback/src/audio_backend/alsa.rs` (+2 -1) 📝 `playback/src/audio_backend/portaudio.rs` (+4 -2) 📝 `playback/src/audio_backend/rodio.rs` (+9 -8) _...and 6 more files_ </details> ### 📄 Description `rustfmt` ~is~ *seems to be* much more stable than when it was removed back in https://github.com/librespot-org/librespot/issues/208 This PR: 1. Removes deprecated `reorder_imports_in_group` as it's now combined with `reorder_imports` 2. Add `rustfmt` checks to Travis (only for stable) 3. Format the entire codebase (with `rustfmt 1.2.2-stable`) 4. Update `Contributing.md` (and `Readme.md` while I was at it) - I also removed removed `nightly` requirement for development - as `rustfmt` is available on the stable channel. Or was there other reasons for the `nightly` requirement? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:19 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:17 +03:00

[PR #885] [CLOSED] Improve discovery #1133

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#885

No description provided.

Rows
Columns