[PR #341] [MERGED] Drop extprim crate (use built-in u128) and reduce usage of byteorder crate (Rust 1.32+) #884

New issue

Closed

opened 2026-02-27 20:00:19 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/341
Author: @willstott101
Created: 6/28/2019
Status: ✅ Merged
Merged: 10/29/2019
Merged by: @sashahilton00

Base: dev ← Head: u128

📝 Commits (2)

ac1c31b Use Rust's built-in unsigned 128 bit integer instead of the extprim crate
a7243ff Use single fixed-width format! macro for SpotifyId.to_base16

📊 Changes

4 files changed (+15 additions, -51 deletions)

View changed files

📝 Cargo.lock (+0 -17)
📝 core/Cargo.toml (+0 -1)
📝 core/src/lib.rs (+0 -1)
📝 core/src/spotify_id.rs (+15 -32)

📄 Description

Peeking around in spotify_id I noticed the use of a now obsolete u128 crate. So I decided to rabbit around an remove the dependency. In the process I got rid of the byteorder dependency (in that file specifically), only to realise the APIs I used were only stabilised in rust 1.32 ...

So I'd understand not merging this just yet, as we may like to keep the 1.30 minimum rust version.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/341 **Author:** [@willstott101](https://github.com/willstott101) **Created:** 6/28/2019 **Status:** ✅ Merged **Merged:** 10/29/2019 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `dev` ← **Head:** `u128` --- ### 📝 Commits (2) - [`ac1c31b`](https://github.com/librespot-org/librespot/commit/ac1c31b78656fa44d8b1a892ad514cbb7ad16fdf) Use Rust's built-in unsigned 128 bit integer instead of the extprim crate - [`a7243ff`](https://github.com/librespot-org/librespot/commit/a7243ff8ce4a3f0bc6eda6ca77592683da9612a4) Use single fixed-width format! macro for SpotifyId.to_base16 ### 📊 Changes **4 files changed** (+15 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+0 -17) 📝 `core/Cargo.toml` (+0 -1) 📝 `core/src/lib.rs` (+0 -1) 📝 `core/src/spotify_id.rs` (+15 -32) </details> ### 📄 Description Peeking around in spotify_id I noticed the use of a now obsolete u128 crate. So I decided to rabbit around an remove the dependency. In the process I got rid of the byteorder dependency (in that file specifically), only to realise the APIs I used were only stabilised in rust 1.32 ... So I'd understand not merging this just yet, as we may like to keep the 1.30 minimum rust version. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:19 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#884

No description provided.

Rows
Columns