mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[PR #339] [CLOSED] Added rudimentary support for podcasts #883
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#883
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/librespot-org/librespot/pull/339
Author: @ReasonableHippo
Created: 6/20/2019
Status: ❌ Closed
Base:
master← Head:master📄 Description
Hi,
I've been trying to get podcast support. I have no experience with rust and it will show. Hopefully, someone more experienced can review what I have done and rework it.
Basically, I added a bool switch in the session.
If a new track is added without gid but just with an uri (this is what is happening for me when i try to play a podcast, this bool is switched and the spotifyid is extracted from the uri).
I also added a new struct called episode with its own metadata and parsing. The base_url is the main thing that is changed. Podcasts also don't have album information, so this is not parsed.
In the player, it is really ugly.
In load_track, I differentiate between episode and track. But as a result of my lack of rust knowledge the only way to get it to compile was to copy the track code and make small adjustments.
This part will have to be reworked. In there, I also set the bitrate to 96 kbits as podcasts don't have higher quality.
So again. This is not suppost to be merged directly, but is intended as a "this might work maybe like this".
However, playback is working for me.
Cheers,
Jan
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
--device ?functionality for the alsa backend #1131