[PR #327] [CLOSED] Add passthrough option for pipe output #880

New issue

Closed

opened 2026-02-27 20:00:18 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/327
Author: @philippe44
Created: 4/5/2019
Status: ❌ Closed

Base: dev ← Head: master

📝 Commits (10+)

9cc30c7 main: Add --pass-through option to setup
ad1f2cb playback: Move pass_through setting to PlayerConfig
8e52921 audio: Unify the two VorbisPacket implementations into AudioPacket
36554a9 audio: Add wrapper error type AudioError
1e81864 audio: Add AudioDecoder trait, exposing only generic types
cb6b911 playback: Use AudioDecoder trait in PlayerState
769c818 audio: Implement a PassthroughDecoder
2e59042 playback: Handle pass_through flag
b7e1ead Merge pull request #1 from bruceg/pass-through
e948fbc audio: Fix two problems breaking compatibility with Rust 1.27

📊 Changes

7 files changed (+227 additions, -29 deletions)

View changed files

📝 audio/src/lewton_decoder.rs (+32 -8)
📝 audio/src/lib.rs (+53 -2)
📝 audio/src/libvorbis_decoder.rs (+33 -8)
➕ audio/src/passthrough_decoder.rs (+82 -0)
📝 playback/src/config.rs (+2 -0)
📝 playback/src/player.rs (+17 -11)
📝 src/main.rs (+8 -0)

📄 Description

Per title, when the pipe output is selected, this adds the possibility to just get the raw ogg file instead of the decoded pcm.
It still misses a seek capability

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/327 **Author:** [@philippe44](https://github.com/philippe44) **Created:** 4/5/2019 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `master` --- ### 📝 Commits (10+) - [`9cc30c7`](https://github.com/librespot-org/librespot/commit/9cc30c79ad1c1044b28f56b4f5d6998792a80d89) main: Add --pass-through option to setup - [`ad1f2cb`](https://github.com/librespot-org/librespot/commit/ad1f2cb6f8c8c3cc2550da2e944ed67ce7785055) playback: Move pass_through setting to PlayerConfig - [`8e52921`](https://github.com/librespot-org/librespot/commit/8e52921b3d9dfd6f09827dbd51061a398c0fd584) audio: Unify the two VorbisPacket implementations into AudioPacket - [`36554a9`](https://github.com/librespot-org/librespot/commit/36554a9a4f0f8a0ef0612fcc0abf16d9fb9ca815) audio: Add wrapper error type AudioError - [`1e81864`](https://github.com/librespot-org/librespot/commit/1e81864dbe2ebcd47fa363cfe33b29d122c9818f) audio: Add AudioDecoder trait, exposing only generic types - [`cb6b911`](https://github.com/librespot-org/librespot/commit/cb6b911e98b370507f32b27b8d9a4ee5985245a0) playback: Use AudioDecoder trait in PlayerState - [`769c818`](https://github.com/librespot-org/librespot/commit/769c8186a60ad4f447de2ef5f7d0cee2bdf697ab) audio: Implement a PassthroughDecoder - [`2e59042`](https://github.com/librespot-org/librespot/commit/2e59042d889833c9a224d5831834345244813c9b) playback: Handle pass_through flag - [`b7e1ead`](https://github.com/librespot-org/librespot/commit/b7e1ead0aac8f7ee3f1aee710d3c1f3902c652d0) Merge pull request #1 from bruceg/pass-through - [`e948fbc`](https://github.com/librespot-org/librespot/commit/e948fbc1654e6703aa1fc3c8f29e56df7d715857) audio: Fix two problems breaking compatibility with Rust 1.27 ### 📊 Changes **7 files changed** (+227 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `audio/src/lewton_decoder.rs` (+32 -8) 📝 `audio/src/lib.rs` (+53 -2) 📝 `audio/src/libvorbis_decoder.rs` (+33 -8) ➕ `audio/src/passthrough_decoder.rs` (+82 -0) 📝 `playback/src/config.rs` (+2 -0) 📝 `playback/src/player.rs` (+17 -11) 📝 `src/main.rs` (+8 -0) </details> ### 📄 Description Per title, when the pipe output is selected, this adds the possibility to just get the raw ogg file instead of the decoded pcm. It still misses a seek capability --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:18 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:16 +03:00

[PR #880] [MERGED] Guard against tracks_len being zero #1128

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#880

No description provided.

Rows
Columns