mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[PR #305] [MERGED] Support for Spotify Radio/Dynamic Playlists #871
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#871
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/librespot-org/librespot/pull/305
Author: @ashthespy
Created: 3/15/2019
Status: ✅ Merged
Merged: 3/20/2019
Merged by: @sashahilton00
Base:
master← Head:dynamic-playlists📝 Commits (4)
96b432aImplement support for dynamic playlists (Radio)c041697Support Dailymixes and refactor dynamic playlistsb0ee8ecTweak malformed gid handling6870c76Limit new context tracks added to frame📊 Changes
3 files changed (+225 additions, -6 deletions)
View changed files
➕
connect/src/context.rs(+86 -0)📝
connect/src/lib.rs(+4 -0)📝
connect/src/spirc.rs(+135 -6)📄 Description
Fixes #57 #267
Some history
While I managed to implement dynamic playlist support back in October, never opened up a PR as https://github.com/librespot-org/librespot/issues/57#issuecomment-446010775:
Recent revelations from reverse engineering efforts by @devgianlu, @sashahilton00 show that we are going to have to bite the bullet and start sprinkling JSON into the mix.
Playlist/Album/Track/Genre radios along with Dailymixes should all work. A point for discussion is on how the new tracks are added to the frame - should we at some point limit it?
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.