[PR #302] [MERGED] Don't panic when the computed MAC doesn't match the client's expected MAC #867

New issue

Closed

opened 2026-02-27 20:00:15 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/302
Author: @kingosticks
Created: 3/13/2019
Status: ✅ Merged
Merged: 3/14/2019
Merged by: @sashahilton00

Base: master ← Head: fix/discover-bad-mac-panic

📝 Commits (3)

4c1562f discover: do not panic on MAC mismatch. (Fixes #289)
83bfdff discover: log the actual HTTP port that is used.
6a60059 main: exit librespot after the first ctrl+c if no currently active spirc session.

📊 Changes

2 files changed (+14 additions, -2 deletions)

View changed files

📝 connect/src/discovery.rs (+12 -2)
📝 src/main.rs (+2 -0)

📄 Description

This just handles this error situation more gracefully. I randomly made up the JSON result error codes/strings.

There's also a couple of other tiny fixes.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/302 **Author:** [@kingosticks](https://github.com/kingosticks) **Created:** 3/13/2019 **Status:** ✅ Merged **Merged:** 3/14/2019 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `master` ← **Head:** `fix/discover-bad-mac-panic` --- ### 📝 Commits (3) - [`4c1562f`](https://github.com/librespot-org/librespot/commit/4c1562f2458e73ccc99b605649872e15e5db66be) discover: do not panic on MAC mismatch. (Fixes #289) - [`83bfdff`](https://github.com/librespot-org/librespot/commit/83bfdffcfe5faa1cee6e1e8408d94d82447e551d) discover: log the actual HTTP port that is used. - [`6a60059`](https://github.com/librespot-org/librespot/commit/6a600596e826bed66d27d931a59699b3fc70e0ef) main: exit librespot after the first ctrl+c if no currently active spirc session. ### 📊 Changes **2 files changed** (+14 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `connect/src/discovery.rs` (+12 -2) 📝 `src/main.rs` (+2 -0) </details> ### 📄 Description This just handles this error situation more gracefully. I randomly made up the JSON result error codes/strings. There's also a couple of other tiny fixes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:15 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#867

No description provided.

Rows
Columns