mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[PR #286] [CLOSED] Null mixer to skip volume control #861
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#861
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/librespot-org/librespot/pull/286
Author: @lautis
Created: 1/20/2019
Status: ❌ Closed
Base:
dev← Head:null-mixer📝 Commits (1)
44713b9Mixer to skip volume control📊 Changes
2 files changed (+33 additions, -0 deletions)
View changed files
📝
playback/src/mixer/mod.rs(+4 -0)➕
playback/src/mixer/nullmixer.rs(+29 -0)📄 Description
Implement a null mixer that does not control volume with software. Having such mechanism is useful if you want to use some external method for volume control, but it isn't available in Librespot.
To support the null mixer, we'd most likely want to also expose volume changes as events that trigger external script.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.