mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[PR #270] [CLOSED] Switch to protobuf-codegen-pure to remove protoc dependency #856
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#856
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/librespot-org/librespot/pull/270
Author: @ashthespy
Created: 11/27/2018
Status: ❌ Closed
Base:
master← Head:protobuf📝 Commits (1)
94f66e8Switch toprotobuf-codegen-pureto removeprotocdependency📊 Changes
10 files changed (+362 additions, -422 deletions)
View changed files
📝
Cargo.lock(+3 -33)📝
protocol/Cargo.toml(+1 -1)📝
protocol/build.rs(+3 -4)➖
protocol/build.sh(+0 -29)📝
protocol/src/authentication.rs(+77 -78)📝
protocol/src/keyexchange.rs(+97 -99)📝
protocol/src/mercury.rs(+21 -20)📝
protocol/src/metadata.rs(+86 -85)📝
protocol/src/pubsub.rs(+4 -3)📝
protocol/src/spirc.rs(+70 -70)📄 Description
Follow up from #251
Switching to
protobuf-codegen-pureensures that thelibrespotcan be built purely using the Rust toolchain now.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.