[PR #255] [MERGED] reap the exit statuses from 'onevent' child processes using futures #852

New issue

Closed

opened 2026-02-27 20:00:12 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/255
Author: @wfraser
Created: 10/16/2018
Status: ✅ Merged
Merged: 10/21/2018
Merged by: @sashahilton00

Base: master ← Head: wfraser/child-exit-wait

📝 Commits (2)

eaac599 reap the exit statuses from 'onevent' child processes
9fa138a implement using tokio-process instead

📊 Changes

4 files changed (+88 additions, -10 deletions)

View changed files

📝 Cargo.lock (+71 -4)
📝 Cargo.toml (+1 -0)
📝 src/main.rs (+10 -1)
📝 src/player_event_handler.rs (+6 -5)

📄 Description

A better fix for #209 than #221 or #254; this uses futures rather than blocking the main thread or spawning a thread for each process.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/255 **Author:** [@wfraser](https://github.com/wfraser) **Created:** 10/16/2018 **Status:** ✅ Merged **Merged:** 10/21/2018 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `master` ← **Head:** `wfraser/child-exit-wait` --- ### 📝 Commits (2) - [`eaac599`](https://github.com/librespot-org/librespot/commit/eaac599ce33c8d1b19804ddbef0c7ddebaa2421a) reap the exit statuses from 'onevent' child processes - [`9fa138a`](https://github.com/librespot-org/librespot/commit/9fa138a116a9b06bdd3440195acedba6c14ed0e4) implement using tokio-process instead ### 📊 Changes **4 files changed** (+88 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+71 -4) 📝 `Cargo.toml` (+1 -0) 📝 `src/main.rs` (+10 -1) 📝 `src/player_event_handler.rs` (+6 -5) </details> ### 📄 Description A better fix for #209 than #221 or #254; this uses futures rather than blocking the main thread or spawning a thread for each process. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:12 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:12 +03:00

[PR #852] [MERGED] Add more platforms to keyexchange.proto #1114

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#852

No description provided.

Rows
Columns