[PR #191] [MERGED] Add support for HTTP proxy #831

New issue

Closed

opened 2026-02-27 20:00:07 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/191
Author: @janderholm
Created: 3/18/2018
Status: ✅ Merged
Merged: 4/6/2018
Merged by: @sashahilton00

Base: master ← Head: master

📝 Commits (5)

6129789 Reformat according to new rustfmt rules
3bdc5e0 Add support for http proxy
1a04e3b Resolve AP through proxy as well
3a14e9a Validate proxy urls better.
96a6978 Update Cargo.lock

📊 Changes

27 files changed (+681 additions, -329 deletions)

View changed files

📝 .travis.yml (+1 -1)
📝 Cargo.lock (+415 -176)
📝 Cargo.toml (+1 -1)
📝 README.md (+1 -1)
📝 audio/src/fetch.rs (+3 -11)
📝 connect/src/discovery.rs (+2 -2)
📝 connect/src/spirc.rs (+4 -7)
📝 core/Cargo.toml (+5 -2)
📝 core/src/apresolve.rs (+44 -9)
📝 core/src/audio_key.rs (+2 -6)
📝 core/src/authentication.rs (+5 -9)
📝 core/src/channel.rs (+1 -1)
📝 core/src/config.rs (+3 -0)
📝 core/src/connection/codec.rs (+1 -2)
📝 core/src/connection/handshake.rs (+2 -5)
📝 core/src/connection/mod.rs (+30 -22)
📝 core/src/diffie_hellman.rs (+8 -16)
📝 core/src/lib.rs (+4 -0)
📝 core/src/mercury/mod.rs (+1 -1)
➕ core/src/proxytunnel.rs (+108 -0)

...and 7 more files

📄 Description

This pull request adds support for tunneling librespot data through an HTTP proxy. It relies on the fact that most http proxies support CONNECT to hosts on port 443.

A CONNECT results in the proxy tunneling all incoming data as is and is commonly used for TLS connections.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/191 **Author:** [@janderholm](https://github.com/janderholm) **Created:** 3/18/2018 **Status:** ✅ Merged **Merged:** 4/6/2018 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (5) - [`6129789`](https://github.com/librespot-org/librespot/commit/612978908f5c6817e48c569cdd55b8b60bbf5a2d) Reformat according to new rustfmt rules - [`3bdc5e0`](https://github.com/librespot-org/librespot/commit/3bdc5e0073938879ecdf898e4812ba20f3ee494d) Add support for http proxy - [`1a04e3b`](https://github.com/librespot-org/librespot/commit/1a04e3b899a4bd6dfe75e8b43988b70f79051c67) Resolve AP through proxy as well - [`3a14e9a`](https://github.com/librespot-org/librespot/commit/3a14e9a6be778fb44df7e69b1586894639026f2a) Validate proxy urls better. - [`96a6978`](https://github.com/librespot-org/librespot/commit/96a69780163588524e270d984c88fe6589ef3263) Update Cargo.lock ### 📊 Changes **27 files changed** (+681 additions, -329 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+1 -1) 📝 `Cargo.lock` (+415 -176) 📝 `Cargo.toml` (+1 -1) 📝 `README.md` (+1 -1) 📝 `audio/src/fetch.rs` (+3 -11) 📝 `connect/src/discovery.rs` (+2 -2) 📝 `connect/src/spirc.rs` (+4 -7) 📝 `core/Cargo.toml` (+5 -2) 📝 `core/src/apresolve.rs` (+44 -9) 📝 `core/src/audio_key.rs` (+2 -6) 📝 `core/src/authentication.rs` (+5 -9) 📝 `core/src/channel.rs` (+1 -1) 📝 `core/src/config.rs` (+3 -0) 📝 `core/src/connection/codec.rs` (+1 -2) 📝 `core/src/connection/handshake.rs` (+2 -5) 📝 `core/src/connection/mod.rs` (+30 -22) 📝 `core/src/diffie_hellman.rs` (+8 -16) 📝 `core/src/lib.rs` (+4 -0) 📝 `core/src/mercury/mod.rs` (+1 -1) ➕ `core/src/proxytunnel.rs` (+108 -0) _...and 7 more files_ </details> ### 📄 Description This pull request adds support for tunneling librespot data through an HTTP proxy. It relies on the fact that most http proxies support CONNECT to hosts on port 443. A CONNECT results in the proxy tunneling all incoming data as is and is commonly used for TLS connections. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:07 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#831

No description provided.

Rows
Columns