[PR #194] [MERGED] Fix pulseaudio playback with Lewton #830

New issue

Closed

opened 2026-02-27 20:00:07 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/194
Author: @brain0
Created: 3/20/2018
Status: ✅ Merged
Merged: 3/23/2018
Merged by: @sashahilton00

Base: master ← Head: fix_pulseaudio

📝 Commits (2)

014533a playback: Only send a packet to the audio backend if it isn't empty
0c18aa5 playback: pulseaudio: Panic in write if data is empty

📊 Changes

2 files changed (+14 additions, -11 deletions)

View changed files

📝 playback/src/audio_backend/pulseaudio.rs (+1 -0)
📝 playback/src/player.rs (+13 -11)

📄 Description

Lewton returns empty packets from next_packet(). This caused problems with the pulseaudio backend.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/194 **Author:** [@brain0](https://github.com/brain0) **Created:** 3/20/2018 **Status:** ✅ Merged **Merged:** 3/23/2018 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `master` ← **Head:** `fix_pulseaudio` --- ### 📝 Commits (2) - [`014533a`](https://github.com/librespot-org/librespot/commit/014533a5831f0fa7ca5460a46ff6a87bf06ee5f5) playback: Only send a packet to the audio backend if it isn't empty - [`0c18aa5`](https://github.com/librespot-org/librespot/commit/0c18aa51adf3abbdc63b393e05b39929191ae6db) playback: pulseaudio: Panic in write if data is empty ### 📊 Changes **2 files changed** (+14 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `playback/src/audio_backend/pulseaudio.rs` (+1 -0) 📝 `playback/src/player.rs` (+13 -11) </details> ### 📄 Description Lewton returns empty packets from next_packet(). This caused problems with the pulseaudio backend. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:07 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#830

No description provided.

Rows
Columns