[PR #163] [CLOSED] Rustfmt syntax correction #820

New issue

Closed

opened 2026-02-27 20:00:05 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/163
Author: @sashahilton00
Created: 2/23/2018
Status: ❌ Closed

Base: master ← Head: rustfmt

📝 Commits (2)

ff1f7e1 Add volume normalisation support
6d24d8e Run rustfmt against whole project

📊 Changes

23 files changed (+513 additions, -311 deletions)

View changed files

📝 Cargo.lock (+1 -0)
📝 audio/src/decrypt.rs (+5 -4)
📝 audio/src/fetch.rs (+45 -25)
📝 audio/src/lewton_decoder.rs (+3 -2)
📝 audio/src/lib.rs (+7 -5)
📝 audio/src/libvorbis_decoder.rs (+7 -4)
📝 examples/play.rs (+6 -3)
📝 playback/Cargo.toml (+1 -0)
📝 playback/src/audio_backend/alsa.rs (+16 -8)
📝 playback/src/audio_backend/jackaudio.rs (+21 -9)
📝 playback/src/audio_backend/mod.rs (+11 -5)
📝 playback/src/audio_backend/pipe.rs (+4 -2)
📝 playback/src/audio_backend/portaudio.rs (+22 -21)
📝 playback/src/audio_backend/pulseaudio.rs (+32 -27)
📝 playback/src/config.rs (+4 -0)
📝 playback/src/lib.rs (+3 -1)
📝 playback/src/mixer/mod.rs (+4 -2)
📝 playback/src/mixer/softmixer.rs (+8 -8)
📝 playback/src/player.rs (+166 -77)
📝 protocol/build.rs (+42 -71)

...and 3 more files

📄 Description

Given that we are now using rustfmt on librespot, I just ran cargo fmt --all against the project, resulting in these changes. I assume that fmt has corrected things to the correct syntax where necessary and that this is something we want to merge?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/163 **Author:** [@sashahilton00](https://github.com/sashahilton00) **Created:** 2/23/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `rustfmt` --- ### 📝 Commits (2) - [`ff1f7e1`](https://github.com/librespot-org/librespot/commit/ff1f7e1d58e1ffc1389ccf4dfbe40b0513237fce) Add volume normalisation support - [`6d24d8e`](https://github.com/librespot-org/librespot/commit/6d24d8e1eb46afb06ce4d20cea45ff3014e29717) Run rustfmt against whole project ### 📊 Changes **23 files changed** (+513 additions, -311 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+1 -0) 📝 `audio/src/decrypt.rs` (+5 -4) 📝 `audio/src/fetch.rs` (+45 -25) 📝 `audio/src/lewton_decoder.rs` (+3 -2) 📝 `audio/src/lib.rs` (+7 -5) 📝 `audio/src/libvorbis_decoder.rs` (+7 -4) 📝 `examples/play.rs` (+6 -3) 📝 `playback/Cargo.toml` (+1 -0) 📝 `playback/src/audio_backend/alsa.rs` (+16 -8) 📝 `playback/src/audio_backend/jackaudio.rs` (+21 -9) 📝 `playback/src/audio_backend/mod.rs` (+11 -5) 📝 `playback/src/audio_backend/pipe.rs` (+4 -2) 📝 `playback/src/audio_backend/portaudio.rs` (+22 -21) 📝 `playback/src/audio_backend/pulseaudio.rs` (+32 -27) 📝 `playback/src/config.rs` (+4 -0) 📝 `playback/src/lib.rs` (+3 -1) 📝 `playback/src/mixer/mod.rs` (+4 -2) 📝 `playback/src/mixer/softmixer.rs` (+8 -8) 📝 `playback/src/player.rs` (+166 -77) 📝 `protocol/build.rs` (+42 -71) _...and 3 more files_ </details> ### 📄 Description Given that we are now using rustfmt on librespot, I just ran ```cargo fmt --all``` against the project, resulting in these changes. I assume that fmt has corrected things to the correct syntax where necessary and that this is something we want to merge? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:05 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:09 +03:00

[PR #820] [MERGED] Implement common SinkError and SinkResult #1099

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#820

No description provided.

Rows
Columns