[GH-ISSUE #95] Fork? #82

Closed
opened 2026-02-27 19:28:44 +03:00 by kerem · 11 comments
Owner

Originally created by @sashahilton00 on GitHub (Jan 29, 2018).
Original GitHub issue: https://github.com/librespot-org/librespot/issues/95

Issue by Bebowi
Thursday Oct 26, 2017 at 14:57 GMT
Originally opened as https://github.com/plietar/librespot/issues/263


Is michaelherger's fork the official one?

Originally created by @sashahilton00 on GitHub (Jan 29, 2018). Original GitHub issue: https://github.com/librespot-org/librespot/issues/95 <a href="https://github.com/Bebowi"><img src="https://avatars3.githubusercontent.com/u/21242387?v=4" align="left" width="96" height="96" hspace="10"></img></a> **Issue by [Bebowi](https://github.com/Bebowi)** _Thursday Oct 26, 2017 at 14:57 GMT_ _Originally opened as https://github.com/plietar/librespot/issues/263_ ---- Is michaelherger's fork the official one?
kerem 2026-02-27 19:28:44 +03:00
  • closed this issue
  • added the
    imported
    label
Author
Owner

@sashahilton00 commented on GitHub (Jan 29, 2018):

Comment by sashahilton00
Thursday Oct 26, 2017 at 14:58 GMT


I think the plan was for Paul to nominate someone else as a maintainer so that we don't lose al issues/PR's by moving to a fork

<!-- gh-comment-id:361277764 --> @sashahilton00 commented on GitHub (Jan 29, 2018): <a href="https://github.com/sashahilton00"><img src="https://avatars3.githubusercontent.com/u/4185362?v=4" align="left" width="48" height="48" hspace="10"></img></a> **Comment by [sashahilton00](https://github.com/sashahilton00)** _Thursday Oct 26, 2017 at 14:58 GMT_ ---- I think the plan was for Paul to nominate someone else as a maintainer so that we don't lose al issues/PR's by moving to a fork
Author
Owner

@sashahilton00 commented on GitHub (Jan 29, 2018):

Comment by Bebowi
Thursday Oct 26, 2017 at 15:00 GMT


I don't know but when I took a look at Fork it seems like this master has been merged to michaelherger's

<!-- gh-comment-id:361277798 --> @sashahilton00 commented on GitHub (Jan 29, 2018): <a href="https://github.com/Bebowi"><img src="https://avatars3.githubusercontent.com/u/21242387?v=4" align="left" width="48" height="48" hspace="10"></img></a> **Comment by [Bebowi](https://github.com/Bebowi)** _Thursday Oct 26, 2017 at 15:00 GMT_ ---- I don't know but when I took a look at Fork it seems like this master has been merged to michaelherger's
Author
Owner

@sashahilton00 commented on GitHub (Jan 29, 2018):

Comment by michaelherger
Thursday Oct 26, 2017 at 15:05 GMT


NO! I only forked it as the base to apply the few changes I need for my Spotty plugin. But I have close to zero Rust experience...

<!-- gh-comment-id:361277831 --> @sashahilton00 commented on GitHub (Jan 29, 2018): <a href="https://github.com/michaelherger"><img src="https://avatars3.githubusercontent.com/u/2789989?v=4" align="left" width="48" height="48" hspace="10"></img></a> **Comment by [michaelherger](https://github.com/michaelherger)** _Thursday Oct 26, 2017 at 15:05 GMT_ ---- NO! I only forked it as the base to apply the few changes I need for my Spotty plugin. But I have close to zero Rust experience...
Author
Owner

@sashahilton00 commented on GitHub (Jan 29, 2018):

Comment by Bebowi
Thursday Oct 26, 2017 at 15:09 GMT


Anybody here who feels experienced enough and has time to do an official fork?

<!-- gh-comment-id:361277858 --> @sashahilton00 commented on GitHub (Jan 29, 2018): <a href="https://github.com/Bebowi"><img src="https://avatars3.githubusercontent.com/u/21242387?v=4" align="left" width="48" height="48" hspace="10"></img></a> **Comment by [Bebowi](https://github.com/Bebowi)** _Thursday Oct 26, 2017 at 15:09 GMT_ ---- Anybody here who feels experienced enough and has time to do an official fork?
Author
Owner

@sashahilton00 commented on GitHub (Jan 29, 2018):

Comment by dtcooper
Wednesday Nov 29, 2017 at 18:57 GMT


Any clear winners here?

<!-- gh-comment-id:361277877 --> @sashahilton00 commented on GitHub (Jan 29, 2018): <a href="https://github.com/dtcooper"><img src="https://avatars0.githubusercontent.com/u/873944?v=4" align="left" width="48" height="48" hspace="10"></img></a> **Comment by [dtcooper](https://github.com/dtcooper)** _Wednesday Nov 29, 2017 at 18:57 GMT_ ---- Any clear winners here?
Author
Owner

@sashahilton00 commented on GitHub (Jan 29, 2018):

Comment by Bebowi
Wednesday Nov 29, 2017 at 19:54 GMT


At the moment there is nobody who wants to win. I'm new to Rust and I think many others too

<!-- gh-comment-id:361277899 --> @sashahilton00 commented on GitHub (Jan 29, 2018): <a href="https://github.com/Bebowi"><img src="https://avatars3.githubusercontent.com/u/21242387?v=4" align="left" width="48" height="48" hspace="10"></img></a> **Comment by [Bebowi](https://github.com/Bebowi)** _Wednesday Nov 29, 2017 at 19:54 GMT_ ---- At the moment there is nobody who wants to win. I'm new to Rust and I think many others too
Author
Owner

@sashahilton00 commented on GitHub (Jan 29, 2018):

Comment by janLo
Wednesday Nov 29, 2017 at 20:00 GMT


How about handing it into an organization of its own and invite known contributors as members. That would enable others than @plietar to approve and merge PullRequests.

<!-- gh-comment-id:361277926 --> @sashahilton00 commented on GitHub (Jan 29, 2018): <a href="https://github.com/janLo"><img src="https://avatars0.githubusercontent.com/u/96146?v=4" align="left" width="48" height="48" hspace="10"></img></a> **Comment by [janLo](https://github.com/janLo)** _Wednesday Nov 29, 2017 at 20:00 GMT_ ---- How about handing it into an organization of its own and invite known contributors as members. That would enable others than @plietar to approve and merge PullRequests.
Author
Owner

@sashahilton00 commented on GitHub (Jan 29, 2018):

Comment by dtcooper
Wednesday Nov 29, 2017 at 22:37 GMT


That's where I'm at too, re: just learning rust. Not a bad idea, @janLo. Is @plietar responding to any librespot noise at able to do that?

<!-- gh-comment-id:361277955 --> @sashahilton00 commented on GitHub (Jan 29, 2018): <a href="https://github.com/dtcooper"><img src="https://avatars0.githubusercontent.com/u/873944?v=4" align="left" width="48" height="48" hspace="10"></img></a> **Comment by [dtcooper](https://github.com/dtcooper)** _Wednesday Nov 29, 2017 at 22:37 GMT_ ---- That's where I'm at too, re: just learning rust. Not a bad idea, @janLo. Is @plietar responding to any librespot noise at able to do that?
Author
Owner

@sashahilton00 commented on GitHub (Jan 29, 2018):

Comment by kingosticks
Thursday Nov 30, 2017 at 02:49 GMT


Nobody has stepped forward so there's nothing to respond to. I think that's the first step here.

<!-- gh-comment-id:361277987 --> @sashahilton00 commented on GitHub (Jan 29, 2018): <a href="https://github.com/kingosticks"><img src="https://avatars2.githubusercontent.com/u/934824?v=4" align="left" width="48" height="48" hspace="10"></img></a> **Comment by [kingosticks](https://github.com/kingosticks)** _Thursday Nov 30, 2017 at 02:49 GMT_ ---- Nobody has stepped forward so there's nothing to respond to. I think that's the first step here.
Author
Owner

@sashahilton00 commented on GitHub (Jan 29, 2018):

Comment by sashahilton00
Monday Jan 29, 2018 at 00:02 GMT


@Bebowi @michaelherger @janLo @dtcooper we've forked librespot into an organisation as a successor and have begun cleanup/implementing PR's and bug fixes. It's available at https://github.com/librespot-org/librespot

<!-- gh-comment-id:361278005 --> @sashahilton00 commented on GitHub (Jan 29, 2018): <a href="https://github.com/sashahilton00"><img src="https://avatars3.githubusercontent.com/u/4185362?v=4" align="left" width="48" height="48" hspace="10"></img></a> **Comment by [sashahilton00](https://github.com/sashahilton00)** _Monday Jan 29, 2018 at 00:02 GMT_ ---- @Bebowi @michaelherger @janLo @dtcooper we've forked librespot into an organisation as a successor and have begun cleanup/implementing PR's and bug fixes. It's available at https://github.com/librespot-org/librespot
Author
Owner

@ComlOnline commented on GitHub (Jan 29, 2018):

We're in the new fork.

<!-- gh-comment-id:361318784 --> @ComlOnline commented on GitHub (Jan 29, 2018): We're in the new fork.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/librespot#82
No description provided.