mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[PR #162] [MERGED] Add volume normalisation support #819
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#819
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/librespot-org/librespot/pull/162
Author: @sashahilton00
Created: 2/23/2018
Status: ✅ Merged
Merged: 2/24/2018
Merged by: @sashahilton00
Base:
master← Head:normalisation📝 Commits (4)
f8db550Add volume normalisation supportfc6c414[ci skip] Correct spelling127f8b7Add constant for readability542ec9dMinor style changes to normalisation code📊 Changes
6 files changed (+93 additions, -10 deletions)
View changed files
📝
Cargo.lock(+1 -0)📝
playback/Cargo.toml(+1 -0)📝
playback/src/config.rs(+4 -0)📝
playback/src/lib.rs(+1 -0)📝
playback/src/player.rs(+79 -9)📝
src/main.rs(+7 -1)📄 Description
The heavy lifting was done by @herrernst. Since his PR has been quiet for a while, and there has been a significant reordering of librespot's structure, this is a reorder/rewrite, taking onboard feedback from #114. Review/suggestion welcomed. Closes #114
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.