mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[PR #149] [CLOSED] Add support for Sentry panic reporting #811
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#811
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/librespot-org/librespot/pull/149
Author: @sashahilton00
Created: 2/12/2018
Status: ❌ Closed
Base:
master← Head:error_reporting📝 Commits (1)
024cde4Add support for Sentry panic reporting📊 Changes
3 files changed (+384 additions, -4 deletions)
View changed files
📝
Cargo.lock(+359 -4)📝
Cargo.toml(+1 -0)📝
src/main.rs(+24 -0)📄 Description
Ok, so the folks over at Sentry.io have given us a FOSS account for the project, allowing us to transparently collect panics when they occur in librespot. Members of librespot-org should be able to sign in and view reported issues, which should aid in triaging and fixing errors/bugs in the long run. Reporting requires no input from users, it is done automatically in the background. However, I'd like views on whether we want to add this, as doing so increases the size of the binary by approx. 5MB in debug mode, due to the need for TLS to secure communication. Also, if people don't feel that this will be useful, we shouldn't bother merge it. Thoughts?
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.