[PR #146] [MERGED] core: remove protobuf_macros #808

New issue

Closed

opened 2026-02-27 20:00:01 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/146
Author: @awiouy
Created: 2/12/2018
Status: ✅ Merged
Merged: 2/12/2018
Merged by: @plietar

Base: master ← Head: protobuf_macros

📝 Commits (4)

e2206ea core: remove protobuf_macros
fa7c037 rewrite
6d56ea7 cleanup
6cff342 cleanup2

📊 Changes

7 files changed (+52 additions, -51 deletions)

View changed files

📝 Cargo.lock (+0 -1)
📝 core/Cargo.toml (+0 -1)
📝 core/build.rs (+0 -8)
📝 core/src/connection/handshake.rs (+28 -23)
📝 core/src/connection/mod.rs (+23 -14)
➖ core/src/lib.in.rs (+0 -2)
📝 core/src/lib.rs (+1 -2)

📄 Description

Addresses #129
@plietar please review
Once this is done I will do the same to connect.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/146 **Author:** [@awiouy](https://github.com/awiouy) **Created:** 2/12/2018 **Status:** ✅ Merged **Merged:** 2/12/2018 **Merged by:** [@plietar](https://github.com/plietar) **Base:** `master` ← **Head:** `protobuf_macros` --- ### 📝 Commits (4) - [`e2206ea`](https://github.com/librespot-org/librespot/commit/e2206ead3a1ce862af2a2beb2d4a6662234d03b4) core: remove protobuf_macros - [`fa7c037`](https://github.com/librespot-org/librespot/commit/fa7c03767e08c0b3a3857ccada9726cb3f7c1c9e) rewrite - [`6d56ea7`](https://github.com/librespot-org/librespot/commit/6d56ea71d381bac82617a1e707da828cd30c2141) cleanup - [`6cff342`](https://github.com/librespot-org/librespot/commit/6cff34227ed823a5cf6b256c704ac57f2b8e4f2d) cleanup2 ### 📊 Changes **7 files changed** (+52 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+0 -1) 📝 `core/Cargo.toml` (+0 -1) 📝 `core/build.rs` (+0 -8) 📝 `core/src/connection/handshake.rs` (+28 -23) 📝 `core/src/connection/mod.rs` (+23 -14) ➖ `core/src/lib.in.rs` (+0 -2) 📝 `core/src/lib.rs` (+1 -2) </details> ### 📄 Description Addresses #129 @plietar please review Once this is done I will do the same to connect. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:01 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:08 +03:00

[PR #808] [CLOSED] Move remaining errors to AlsaError #1091

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#808

No description provided.

Rows
Columns