[PR #139] [MERGED] Rustify some recent changes according to plietar #804

New issue

Closed

opened 2026-02-27 20:00:00 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/139
Author: @michaelherger
Created: 2/11/2018
Status: ✅ Merged
Merged: 2/11/2018
Merged by: @sashahilton00

Base: master ← Head: rustify

📝 Commits (3)

1248796 Somewhat uniform coding style might help myself to better understand Rust :-)
5ed4639 Remove the -z as an alias for the --zeroconf-port parameter
4636cb7 Print more descriptive error message when we fail to bind zeroconf to the given port.

📊 Changes

3 files changed (+18 additions, -25 deletions)

View changed files

📝 .gitignore (+2 -0)
📝 discovery/src/discovery.rs (+1 -1)
📝 src/main.rs (+15 -24)

📄 Description

This PR replaces pull request #111.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/139 **Author:** [@michaelherger](https://github.com/michaelherger) **Created:** 2/11/2018 **Status:** ✅ Merged **Merged:** 2/11/2018 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `master` ← **Head:** `rustify` --- ### 📝 Commits (3) - [`1248796`](https://github.com/librespot-org/librespot/commit/12487966b274aff7325a7cae6355f7692681ccf2) Somewhat uniform coding style might help myself to better understand Rust :-) - [`5ed4639`](https://github.com/librespot-org/librespot/commit/5ed4639cca9c13035b72ec58a2f1a56f1571cf63) Remove the -z as an alias for the --zeroconf-port parameter - [`4636cb7`](https://github.com/librespot-org/librespot/commit/4636cb71b96785bc44004c77ec0034e7eca3b140) Print more descriptive error message when we fail to bind zeroconf to the given port. ### 📊 Changes **3 files changed** (+18 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+2 -0) 📝 `discovery/src/discovery.rs` (+1 -1) 📝 `src/main.rs` (+15 -24) </details> ### 📄 Description This PR replaces pull request #111. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:00 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:07 +03:00

[PR #804] [MERGED] Make CI ignore things that should not trigger build tests #1089

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#804

No description provided.

Rows
Columns