mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[GH-ISSUE #19] Shuffle/Repeat buttons are not fully functional. #8
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#8
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mrwsl on GitHub (Jan 29, 2018).
Original GitHub issue: https://github.com/librespot-org/librespot/issues/19
Originally assigned to: @roderickvd, @kingosticks on GitHub.
Good to see you guys keep this project alive!
Basically copy/paste from plietar's repo issue #82
@ComlOnline commented on GitHub (Jan 29, 2018):
Just so you know the shuffle and repeat from @kingosticks was added in #2, I know there are still some things to fix so I'll keep this open:
See his comments here and here.
@kingosticks commented on GitHub (Jan 29, 2018):
An update in regards to the above. It's become obvious this isn't a good idea as librespot may have never seen a non-shuffled version of the tracklist (e.g. a mobile client shuffled the tracklist whilst disconnected from the network). Re-fetching the tracks from the context uri is simplest. You just have to ensure you save the queued tracks before doing so as they are not part of the context and would otherwise be lost. I think the official Android client has a bug here as if you enable/disable shuffle a few times in a row you sometimes suddenly lose the queued tracks.
@kingosticks commented on GitHub (Mar 20, 2019):
The different repeat modes (single vs all) is still covered by this issue but the remaining shuffle part of this is superseded by https://github.com/librespot-org/librespot/issues/264
@louy2 commented on GitHub (Apr 3, 2020):
Running into this, cannot repeat a single track. Anything I can help with?
@roderickvd commented on GitHub (Aug 7, 2021):
Will be tackling this under
new-apiefforts.@sewnie commented on GitHub (Mar 13, 2022):
Status?
@roderickvd commented on GitHub (Mar 13, 2022):
Same.
@ghost commented on GitHub (Apr 30, 2022):
Status?
@roderickvd commented on GitHub (Apr 30, 2022):
Come on.
@xsolvia commented on GitHub (May 8, 2022):
would like to see this happen as well.
@ghost commented on GitHub (Aug 15, 2022):
In hindsight I should likely apologize as I came into this discussion section with frustration and confusion. I have no intention of rushing your development or forcing you to tunnel vision on just the repeat function. It's actually not that big of a deal in my life, Spotify. Continue focusing on what's important and spotifyd will be everything you're seeing ahead. Best of luck to you.
@roderickvd commented on GitHub (Sep 30, 2022):
Reporting back after some time: with the current
spircwe have no way of indicating that we support single repeat mode, so the client doesn't offer it. Maybe it will be possible when we start publishing our device capabilities on HTTPS, which is targeted for v0.5. Otherwise it will require thedealerinterface which will certainly have to wait until v0.6.@arch-btw commented on GitHub (Nov 27, 2022):
For anyone facing this issue, the repeat single track option works with librespot-java, this might be a temporary solution until this gets fixed in the Rust version 👍
@sewnie commented on GitHub (Nov 27, 2022):
i would rather live with the proprietary spotify client than to have to use that
@kinkard commented on GitHub (Jan 11, 2024):
@roderickvd Can you elaborate a bit about the
dealerinterface or link some reference about it?The "repeat one" functionality is quite important for my use case and I want to try to dig into this topic.
@roderickvd commented on GitHub (Jan 13, 2024):
librespot-javahas implemented it. Basically it's a complete move away from Mercury-basedspirctowards a web socket interface. One could port it fromlibrespot-java: it requires major breaking (i.e. non-incremental) changes under the hood oflibrespot.