[PR #112] [MERGED] Feature flag for selecting dns service #784

New issue

Closed

opened 2026-02-27 19:59:56 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 19:59:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/112
Author: @sashahilton00
Created: 1/31/2018
Status: ✅ Merged
Merged: 1/31/2018
Merged by: @sashahilton00

Base: master ← Head: feature_dns

📝 Commits (2)

d923f3b Add with-dns-sd feature flag
7a58e6d fix addr in wrong place

📊 Changes

4 files changed (+52 additions, -3 deletions)

View changed files

📝 Cargo.lock (+11 -0)
📝 Cargo.toml (+5 -2)
📝 src/discovery.rs (+30 -0)
📝 src/lib.rs (+6 -1)

📄 Description

Code for allowing one to use dns-sd instead of mdns with the --features "dns-sd" compile time flag. Documentation needs to be added. Review and suggestions welcomed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/112 **Author:** [@sashahilton00](https://github.com/sashahilton00) **Created:** 1/31/2018 **Status:** ✅ Merged **Merged:** 1/31/2018 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `master` ← **Head:** `feature_dns` --- ### 📝 Commits (2) - [`d923f3b`](https://github.com/librespot-org/librespot/commit/d923f3bad377fc17add533e8de294fdf8bfcee3d) Add with-dns-sd feature flag - [`7a58e6d`](https://github.com/librespot-org/librespot/commit/7a58e6d561d91aa5d41d2da3ab641074aea68147) fix addr in wrong place ### 📊 Changes **4 files changed** (+52 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+11 -0) 📝 `Cargo.toml` (+5 -2) 📝 `src/discovery.rs` (+30 -0) 📝 `src/lib.rs` (+6 -1) </details> ### 📄 Description Code for allowing one to use dns-sd instead of mdns with the ```--features "dns-sd"``` compile time flag. Documentation needs to be added. Review and suggestions welcomed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 19:59:56 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:04 +03:00

[PR #784] [CLOSED] Give the Option Hints Meaning #1076

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#784

No description provided.

Rows
Columns