[PR #9] [MERGED] Update dependencies and fix the use of deprecated functionality #777

New issue

Closed

opened 2026-02-27 19:59:55 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 19:59:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/9
Author: @brain0
Created: 1/21/2018
Status: ✅ Merged
Merged: 1/26/2018
Merged by: @ComlOnline

Base: master ← Head: fix_deprecated

📝 Commits (8)

a1a3a2e core: Remove an unneeded use warning
6443552 Use futures::sync::oneshot::Sender::send() instead of the deprecated complete()
0bdf9aa Update all dependencies
5237203 Remove usage of deprecated BoxFuture, BoxStream and BoxSink
630de8c Use futures::sync::mpsc::UnboundedSender::unbounded_send() instead of the deprecated send()
d36017d Remove usage of deprecated tokio_core::io
2465b0f Refactor the discovery module to remove usage of deprecated functions
6b8a21d Increase required Rust version to 1.18.0.

📊 Changes

23 files changed (+462 additions, -432 deletions)

View changed files

📝 .travis.yml (+2 -4)
📝 Cargo.lock (+311 -273)
📝 Cargo.toml (+1 -0)
📝 README.md (+1 -1)
📝 audio/src/fetch.rs (+1 -1)
📝 core/Cargo.toml (+2 -0)
📝 core/build.rs (+3 -1)
📝 core/src/audio_key.rs (+5 -5)
📝 core/src/channel.rs (+14 -14)
📝 core/src/connection/codec.rs (+21 -14)
📝 core/src/connection/handshake.rs (+11 -9)
📝 core/src/connection/mod.rs (+7 -7)
📝 core/src/lib.rs (+2 -3)
📝 core/src/mercury/mod.rs (+16 -16)
📝 core/src/session.rs (+10 -10)
📝 core/src/util/spotify_id.rs (+2 -0)
📝 metadata/src/lib.rs (+4 -4)
📝 src/discovery.rs (+23 -37)
📝 src/keymaster.rs (+4 -4)
📝 src/lib.rs (+0 -3)

...and 3 more files

📄 Description

librespot uses outdated versions of futures and tokio. It also uses deprecated functionality from those crates. This patch series modernizes the code base and removes all use of deprecated functions and types.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/9 **Author:** [@brain0](https://github.com/brain0) **Created:** 1/21/2018 **Status:** ✅ Merged **Merged:** 1/26/2018 **Merged by:** [@ComlOnline](https://github.com/ComlOnline) **Base:** `master` ← **Head:** `fix_deprecated` --- ### 📝 Commits (8) - [`a1a3a2e`](https://github.com/librespot-org/librespot/commit/a1a3a2e7722355c43e5668cd1cc0dcfcc73aa062) core: Remove an unneeded use warning - [`6443552`](https://github.com/librespot-org/librespot/commit/644355269e8825a4b6669fd2a058ae8d4be0e938) Use futures::sync::oneshot::Sender::send() instead of the deprecated complete() - [`0bdf9aa`](https://github.com/librespot-org/librespot/commit/0bdf9aa08035b9fde2346cd196cd19ab38a72239) Update all dependencies - [`5237203`](https://github.com/librespot-org/librespot/commit/5237203899c416b772d5ec797b3fdb911922677c) Remove usage of deprecated BoxFuture, BoxStream and BoxSink - [`630de8c`](https://github.com/librespot-org/librespot/commit/630de8c0a9b09981f5cdfa418fd26a07756665bd) Use futures::sync::mpsc::UnboundedSender::unbounded_send() instead of the deprecated send() - [`d36017d`](https://github.com/librespot-org/librespot/commit/d36017d6f06bc8ba9f455d856e68da1983a77fe7) Remove usage of deprecated tokio_core::io - [`2465b0f`](https://github.com/librespot-org/librespot/commit/2465b0f57ff2224b704bfaddb548a6eb115483a2) Refactor the discovery module to remove usage of deprecated functions - [`6b8a21d`](https://github.com/librespot-org/librespot/commit/6b8a21db9fe17d3d1d703fbfd9c82b75b7f70150) Increase required Rust version to 1.18.0. ### 📊 Changes **23 files changed** (+462 additions, -432 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+2 -4) 📝 `Cargo.lock` (+311 -273) 📝 `Cargo.toml` (+1 -0) 📝 `README.md` (+1 -1) 📝 `audio/src/fetch.rs` (+1 -1) 📝 `core/Cargo.toml` (+2 -0) 📝 `core/build.rs` (+3 -1) 📝 `core/src/audio_key.rs` (+5 -5) 📝 `core/src/channel.rs` (+14 -14) 📝 `core/src/connection/codec.rs` (+21 -14) 📝 `core/src/connection/handshake.rs` (+11 -9) 📝 `core/src/connection/mod.rs` (+7 -7) 📝 `core/src/lib.rs` (+2 -3) 📝 `core/src/mercury/mod.rs` (+16 -16) 📝 `core/src/session.rs` (+10 -10) 📝 `core/src/util/spotify_id.rs` (+2 -0) 📝 `metadata/src/lib.rs` (+4 -4) 📝 `src/discovery.rs` (+23 -37) 📝 `src/keymaster.rs` (+4 -4) 📝 `src/lib.rs` (+0 -3) _...and 3 more files_ </details> ### 📄 Description librespot uses outdated versions of futures and tokio. It also uses deprecated functionality from those crates. This patch series modernizes the code base and removes all use of deprecated functions and types. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 19:59:55 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:03 +03:00

[PR #777] [MERGED] Various code improvements #1074

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#777

No description provided.

Rows
Columns