mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[PR #10] [MERGED] Add --progressive-volume option. Increase volume slowly at low level,… #775
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#775
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/librespot-org/librespot/pull/10
Author: @thekr1s
Created: 1/25/2018
Status: ✅ Merged
Merged: 1/30/2018
Merged by: @sashahilton00
Base:
master← Head:progressive-voume-control📝 Commits (8)
4870acdAdd --progressive-volume option. Increase volume slowly at low level, faster at higher level67adb06update README.mdf5b70c4update README.mdde7d341update README.mdbec6b8cChanged volume control after discussion: https://github.com/librespot-org/librespot/pull/10f0061a2Merge branch 'progressive-voume-control' of https://github.com/thekr1s/librespot into progressive-voume-control0b491b8Merge branch 'progressive-voume-control' of https://github.com/thekr1s/librespot into progressive-voume-control871ab2bMerge branch 'progressive-voume-control' of https://github.com/thekr1s/librespot into progressive-voume-control📊 Changes
1 file changed (+31 additions, -8 deletions)
View changed files
📝
src/spirc.rs(+31 -8)📄 Description
… faster at higher level
I use a Raspberry pi with a hifiberry. I installed run OSMC (includes Kodi) on it and added librespot. The volume control of librespot is very dfferent from Kodi. In the first 5 percent of the volume level in librespot, the volume increases very fast to about the same level Kodi has at 50%. That is what I try to solve here.
I'm not a mathematic, so I implemented some 'by trial' algorithm.
Note: I did not know how to test the handle_volume_up() and handle_volume_down() functions in spirc.rs.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
cargo update#1071