mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 00:05:55 +03:00
[GH-ISSUE #87] Crash on some songs #76
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#76
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sashahilton00 on GitHub (Jan 29, 2018).
Original GitHub issue: https://github.com/librespot-org/librespot/issues/87
Tuesday Sep 05, 2017 at 18:53 GMT
Originally opened as https://github.com/plietar/librespot/issues/247
Librespot crashes on some songs, this is 100% reproducible (pi musicbox and libreelec).
The song causing the crash is not working with chromecast either, so probably spotify doesn't allow to play this song externally. It would be nice if we could just skip this song instead of the assertion :-).
@sashahilton00 commented on GitHub (Jan 29, 2018):
Wednesday Sep 06, 2017 at 03:57 GMT
It would probably be helpful if you could give some track IDs causing this.
@sashahilton00 commented on GitHub (Jan 29, 2018):
Monday Sep 18, 2017 at 17:57 GMT
@michaelherger
How can I find these IDs as parsing fails?
@sashahilton00 commented on GitHub (Jan 29, 2018):
Tuesday Sep 19, 2017 at 05:35 GMT
In the Spotify applications there's a "..." menu item which allows you to copy the item's URI.
@sashahilton00 commented on GitHub (Jan 29, 2018):
Tuesday Sep 19, 2017 at 17:41 GMT
Something strange is going on here, spotify doesn't have URLs for the crashing songs.
"Delen" = "Share" and allows me to get the URL.
Normal song:
Crashing song:
@sashahilton00 commented on GitHub (Jan 29, 2018):
Tuesday Sep 19, 2017 at 18:32 GMT
It looks like the song in the playlist is refering to a song on an album
that doesn't exists anymore on spotify
probably the spotify software searches for an alternative and librespot
doesn't.
that's my five cents anyway...
cheers
2017-09-19 19:41 GMT+02:00 Glenn-1990 notifications@github.com:
@sashahilton00 commented on GitHub (Jan 29, 2018):
Friday Dec 22, 2017 at 16:11 GMT
I hit the same, seems a lot like what you suggested.
Since librespot is not maintained anymore I suppose it's just tough luck :(
@sashahilton00 commented on GitHub (Jan 29, 2018):
Friday Dec 22, 2017 at 16:47 GMT
But it does look like it tries to:
github.com/plietar/librespot@ddfc28f99f/src/player.rs (L351)@sashahilton00 commented on GitHub (Jan 29, 2018):
Friday Dec 22, 2017 at 18:59 GMT
An example of a failing song would be helpful.
@sashahilton00 commented on GitHub (Jan 29, 2018):
Wednesday Jan 03, 2018 at 14:08 GMT
To reproduce, you can create a playlist on Spotify desktop, add a local directory and then add a local song to the playlist. When librespot then tries to play that song, this assertion will fail since it does not correspond to a song available on Spotify.
@sashahilton00 commented on GitHub (Feb 25, 2018):
Since this issue has no backtrace, no sample songs to reproduce, and no further reports within the past couple of months, I'm closing this. Please reopen with a backtrace and sample songs if this error still occurs.