mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 00:05:55 +03:00
[GH-ISSUE #81] pause after last track has finished #71
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#71
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sashahilton00 on GitHub (Jan 29, 2018).
Original GitHub issue: https://github.com/librespot-org/librespot/issues/81
Saturday Aug 26, 2017 at 17:20 GMT
Originally opened as https://github.com/plietar/librespot/pull/239
Currently, librespot plays endlessly: After the last track in a playlist/album it continues playing the first one.
This changes the behaviour to match the official Spotify client: The first track is loaded again, but the player is paused.
See #237
herrernst included the following code: https://github.com/plietar/librespot/pull/239/commits
@sashahilton00 commented on GitHub (Jan 29, 2018):
Tuesday Sep 12, 2017 at 17:21 GMT
+1 would really like to see this. @herrernst any way you could include this PR in your raspberry pi builds?
@sashahilton00 commented on GitHub (Jan 29, 2018):
Wednesday Sep 20, 2017 at 20:22 GMT
What about adding this as a runtime option?
@sashahilton00 commented on GitHub (Jan 29, 2018):
Tuesday Sep 26, 2017 at 14:37 GMT
I don't think it should be included as a runtime option. This is a good stopgap measure until someone gets the repeat button working.
@sashahilton00 commented on GitHub (Jan 29, 2018):
Tuesday Sep 26, 2017 at 18:16 GMT
I also think this shouldn't be an extra option, but the repeat mode should be toggled/controlled with the Spotify app as raised in #237
@sashahilton00 commented on GitHub (Jan 29, 2018):
Tuesday Sep 26, 2017 at 18:43 GMT
I would agree that that is the best possible option. Unfortunately, I do not have any experience with rust and it doesn't seem to share a lot of similarities with languages I am familiar with. If you have the time and energy to implement that, it would be fantastic. It does seem that the repeat status is received in protocol/src/spirc.rs, and the original file (src/spirc.rs) could simply have the logic self.load_track(!was_last_track || is_repeating);
@sashahilton00 commented on GitHub (Jan 29, 2018):
Monday Oct 30, 2017 at 09:42 GMT
So I had a go at integrating this with the connect side of things, my first stab at rust: https://github.com/plietar/librespot/compare/master...kingosticks:master
However, it's not quite there yet as it's missing the ability to repeat just one song which is available on the native client (you toggle repeat, repeat one, and off through the same control on the Android app). The repeat state is just a boolean so maybe there's a different bit of state to control repeat one (single?). Any ideas welcome.
I also wanted to do shuffle but doing the actual track shuffle is a bit more work.
@ComlOnline commented on GitHub (Jan 29, 2018):
I think this was fixed due to #2. I've just tested it and it stopped at the end of a playlist.
Could someone else confirm the same?
@sashahilton00 commented on GitHub (Jan 29, 2018):
This was fixed, however just looking over that PR, we need to open a new issue for Shuffle and Repeat functionality, which isn't fully implemented.
@ComlOnline commented on GitHub (Jan 29, 2018):
@sashahilton00 I think #19 covers this.
@sashahilton00 commented on GitHub (Jan 29, 2018):
@ComlOnline agreed.