starred/librespot

Fork 0

mirror of https://github.com/librespot-org/librespot.git synced 2026-04-27 08:15:50 +03:00

[GH-ISSUE #1453] Add `add_to_queue` method to `Spirc` #652

New issue

Closed

opened 2026-02-27 19:31:47 +03:00 by kerem · 2 comments

kerem commented

2026-02-27 19:31:47 +03:00

Owner

Originally created by @photovoltex on GitHub (Jan 20, 2025).
Original GitHub issue: https://github.com/librespot-org/librespot/issues/1453

Is your feature request related to a problem? Please describe.
Currently you need to use the api to add an item to the queue even when we are the active device. As the handling exists anyways for the dealer handling, we could now expose the option to the Spirc.

Describe the solution you'd like
Add a add_to_queue method to the Spirc. The item should probably be a SpotifyId. This should (as most other Spirc methods) only work when we are the active device.

Originally created by @photovoltex on GitHub (Jan 20, 2025). Original GitHub issue: https://github.com/librespot-org/librespot/issues/1453 **Is your feature request related to a problem? Please describe.** Currently you need to use the api to add an item to the queue even when we are the active device. As the handling exists anyways for the dealer handling, we could now expose the option to the `Spirc`. **Describe the solution you'd like** Add a `add_to_queue` method to the `Spirc`. The item should probably be a `SpotifyId`. This should (as most other `Spirc` methods) only work when we are the active device.

kerem

2026-02-27 19:31:47 +03:00

closed this issue
added the
enhancement
label

kerem commented

2026-02-27 19:31:47 +03:00

Author

Owner

@kingosticks commented on GitHub (Jan 20, 2025):

This should (as most other Spirc methods) only work when we are the active device.

Are you 100% sold on this? It seems like a useful thing for the library to be able to do. Maybe a rethink on some of this belongs in a separate issue.

@kingosticks commented on GitHub (Jan 20, 2025): > This should (as most other Spirc methods) only work when we are the active device. Are you 100% sold on this? It seems like a useful thing for the library to be able to do. Maybe a rethink on some of this belongs in a separate issue.

kerem commented

2026-02-27 19:31:47 +03:00

Author

Owner

@photovoltex commented on GitHub (Jan 20, 2025):

As it is only in the Spirc and currently we only execute SpircCommands when we are the active device, this seemed the logical conclusion to me.

But we could also rethink the current state and maybe implement something that could also handle the commands when we are not the active device. I'm completely open for ideas and solution :D

@photovoltex commented on GitHub (Jan 20, 2025): As it is only in the `Spirc` and currently we only execute `SpircCommand`s when we are the active device, this seemed the logical conclusion to me. But we could also rethink the current state and maybe implement something that could also handle the commands when we are not the active device. I'm completely open for ideas and solution :D

kerem referenced this issue

2026-02-27 20:00:46 +03:00

[PR #652] [MERGED] clean up imports & clippy lints #1000

kerem referenced this issue

2026-02-27 20:00:47 +03:00

[PR #665] [MERGED] Tokio migration #1006

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#652

No description provided.

Rows
Columns

[GH-ISSUE #1453] Add add_to_queue method to Spirc #652

[GH-ISSUE #1453] Add `add_to_queue` method to `Spirc` #652