mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 16:25:52 +03:00
[GH-ISSUE #1326] Build failures caused by nasm #606
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#606
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @x528491x on GitHub (Sep 6, 2024).
Original GitHub issue: https://github.com/librespot-org/librespot/issues/1326
Ever since the version bump for hyper-rustls, nasm becomes a dependency and it creates trouble while building.
Building with
cargo build --releaseworks, whereas when using cross, it does not work.I see that you've also replaced cross with cargo in your build tests.
Would really like a fix for these build errors and the tagging of a new release as simply using the "latest" has become unpredictable
@x528491x commented on GitHub (Sep 6, 2024):
I just read https://github.com/librespot-org/librespot/pull/1318.
So will cross not work going forward and all cross builds have to be done only with cargo?
@roderickvd commented on GitHub (Sep 6, 2024):
@yubiuser
@x528491x commented on GitHub (Sep 6, 2024):
Issue reported upstream
https://github.com/aws/aws-lc-rs/issues/514
@x528491x commented on GitHub (Sep 6, 2024):
Issue probably fixed upstream:
https://github.com/aws/aws-lc-rs/issues/514#issuecomment-2333908415
@yubiuser commented on GitHub (Sep 6, 2024):
The issue likely is with
cross: it setups a docker container to actually do the build and it uses a fairly outdated base image (esp. if you use the tagged version and not installing from github directly). All dependencies that can't be downloaded as pre-build crates need to find their way into the image used. This can be quite a challenge (this is why I removedcrossfrom librespot). But I see there might be somenasmpre-build crates soon....@roderickvd commented on GitHub (Sep 16, 2024):
Fixed now?
@fivebanger commented on GitHub (Sep 20, 2024):
Edit:
Moved to https://github.com/librespot-org/librespot/issues/1346
@yubiuser commented on GitHub (Sep 20, 2024):
@fivebanger
The error message indicates that your issue is not dircetly related to the issue reported by the OP (and you're not using
cross). I would advice to open a new issue to not derail the thread.@fivebanger commented on GitHub (Sep 20, 2024):
I have created a new issue.