[GH-ISSUE #62] Certain names don't work on discovery mode #49

Closed
opened 2026-02-27 19:28:32 +03:00 by kerem · 2 comments
Owner

Originally created by @sashahilton00 on GitHub (Jan 29, 2018).
Original GitHub issue: https://github.com/librespot-org/librespot/issues/62

Issue by WhyNotHugo
Wednesday Jun 14, 2017 at 01:47 GMT
Originally opened as https://github.com/plietar/librespot/issues/200


It looks like certain names don't work on discover mode. All my initial testing was using "librespot@$HOSTNAME" (eg: librespot@athena.barrera.io".

I debugged fiddled around for quite a while thinking discovery was broken, and it's not -- unless you use . in the name (The @ looks okay though)t. This is probably not the only invalid character (maybe it needs escaping?).


Actually the problem is probably some form of escaping, since the official spotify client does work with . in the device name.

Originally created by @sashahilton00 on GitHub (Jan 29, 2018). Original GitHub issue: https://github.com/librespot-org/librespot/issues/62 <a href="https://github.com/WhyNotHugo"><img src="https://avatars1.githubusercontent.com/u/730811?v=4" align="left" width="96" height="96" hspace="10"></img></a> **Issue by [WhyNotHugo](https://github.com/WhyNotHugo)** _Wednesday Jun 14, 2017 at 01:47 GMT_ _Originally opened as https://github.com/plietar/librespot/issues/200_ ---- It looks like certain names don't work on discover mode. All my initial testing was using "librespot@$HOSTNAME" (eg: librespot@athena.barrera.io". I ~debugged~ fiddled around for quite a while thinking discovery was broken, and it's not -- unless you use `.` in the name (The `@` looks okay though)t. This is probably not the only invalid character (maybe it needs escaping?). --- Actually the problem *is* probably some form of escaping, since the official spotify client does work with `.` in the device name.
kerem 2026-02-27 19:28:32 +03:00
Author
Owner

@ComlOnline commented on GitHub (Jan 29, 2018):

I've just done some testing. a . is fine in the name as long as its not as the first or last character.

If it is used you will get

WARN:mdns::fsm: couldn't parse packet from V4(<librespot internal ipv4 here>:5353): type 1891 is invaild
WARN:mdns::fsm: couldn't parse packet from V6(<librespot internal ipv6 here>:5353): type 1891 is invaild
<!-- gh-comment-id:361385284 --> @ComlOnline commented on GitHub (Jan 29, 2018): I've just done some testing. a `.` is fine in the name as long as its not as the first or last character. If it is used you will get ``` WARN:mdns::fsm: couldn't parse packet from V4(<librespot internal ipv4 here>:5353): type 1891 is invaild WARN:mdns::fsm: couldn't parse packet from V6(<librespot internal ipv6 here>:5353): type 1891 is invaild
Author
Owner

@ComlOnline commented on GitHub (Jan 29, 2018):

Due to the very edge case nature of this I'm going to close it. If a real need to a . at the beginning and end of a name arises it can be reopened.

<!-- gh-comment-id:361387374 --> @ComlOnline commented on GitHub (Jan 29, 2018): Due to the very edge case nature of this I'm going to close it. If a real need to a `.` at the beginning and end of a name arises it can be reopened.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/librespot#49
No description provided.