mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[GH-ISSUE #1031] new-api is no longer needed in test workflow #488
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#488
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @michaelherger on GitHub (Aug 1, 2022).
Original GitHub issue: https://github.com/librespot-org/librespot/issues/1031
See
github.com/librespot-org/librespot@e9f3b6d290/.github/workflows/test.yml (L6)@roderickvd commented on GitHub (Aug 1, 2022):
Good catch. You want to put in a PR?
@michaelherger commented on GitHub (Aug 1, 2022):
Done - https://github.com/librespot-org/librespot/pull/1032
Do you have a policy of no merge without PR? I would have thought it would be easier for you to just DIY 😀.
Thanks for your ongoing effort! Looking forward to giving latest development a try! I'm using a fork and am updating it with latest dev right now. Will be interesting to see the outcome.
@roderickvd commented on GitHub (Aug 1, 2022):
That was the policy but I’m being a bit more liberal with it myself.
Generally I appreciate all work others can take out of my hands — it’s easy for me to hit the merge button on GitHub and doesn’t require me to have my own development environment with me.
Really encouraging to hear everyone picking up development and contributing!