mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[GH-ISSUE #653] [Tokio migration] Proxy support #381
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#381
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Johannesd3 on GitHub (Feb 25, 2021).
Original GitHub issue: https://github.com/librespot-org/librespot/issues/653
Proxy support was one of the few things that weren't easy to migrate to tokio 1.0, mainly because hyper-proxy is not migrated yet. While #583 added basic proxy support again, it was only tested with a quickly set up local proxy server instance. In the discussion of this PR, 3 alternatives came up (read there for their advantages an drawbacks):
Since I don't know anything about proxy servers (and don't need them), I would appreciate if someone else takes a look at it.
@sashahilton00 Would it be possible to use milestones or custom labels to keep track of the issues related to the tokio migration?
@Johannesd3 commented on GitHub (Mar 8, 2021):
They did update hyper-proxy, so we can make progress here.
BTW, while re-implementing proxy support I did not really care for the format of addresses (e.g. whether port or protocol are specified), I think the behaviour could differ compared to before. We should check this.