mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 00:05:55 +03:00
[GH-ISSUE #600] No sinc closed event when connection is lost. #376
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#376
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @aliher1911 on GitHub (Feb 11, 2021).
Original GitHub issue: https://github.com/librespot-org/librespot/issues/600
I sometimes experience connection issues where librespot loses connection:
ERROR librespot_core::session] Os { code: 104, kind: ConnectionReset, message: "Connection reset by peer" }
and playback is stopped.
In that case sink closed event is not generated.
I'm using those events to power off speakers when there's no playback and turn them back on when sink start event arrives. So if connection drops, monitoring program keeps everything powered. It would be helpful to either send sink stop or some other event indicating that playback was stopped.
@sashahilton00 commented on GitHub (Feb 12, 2021):
Related to #134
@roderickvd commented on GitHub (May 24, 2021):
Will be fixed when we get the new API in, which is factoring in reconnection support from the ground up.
@roderickvd commented on GitHub (Jun 14, 2021):
Duplicate of #276.