mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[GH-ISSUE #596] Move get_credentials function to the application #373
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#373
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Johannesd3 on GitHub (Feb 9, 2021).
Original GitHub issue: https://github.com/librespot-org/librespot/issues/596
I would like to suggest another breaking change before 0.2: removing
fn get_credentials. Why? It does not provide any functionality directly concerning Spotify, but it's rather a very specialized function, written with a concrete application/daemon in mind.Yes, spotifyd uses this function too, or better: they abuse it. Instead of prompting in the
promptcallback they abort the application. Which shows that this function is too specialized for their usecase too.So I would suggest moving it to the application. It's not hard to implement, so every dependency using this function could implement it's own more spezialized function. Do you agree?