starred/librespot

Fork 0

mirror of https://github.com/librespot-org/librespot.git synced 2026-04-27 08:15:50 +03:00

[GH-ISSUE #579] Playback crashes when switching users #368

New issue

Closed

opened 2026-02-27 19:30:15 +03:00 by kerem · 5 comments

kerem commented

2026-02-27 19:30:15 +03:00

Owner

Originally created by @mikeszila on GitHub (Jan 24, 2021).
Original GitHub issue: https://github.com/librespot-org/librespot/issues/579

I do not use username or password options when starting librespot. I can connect to librespot with multiple different clients as long as they are the same user. If I then try to connect with a client logged in with a different user, librespot crashes. I don't even have to press play for this to happen. Below is the only output when this happens. Previous versions of librespot did not exhibit this behaviour, though I'm not sure when it started.


DEBUG librespot_connect::discovery] Post "/" {}
DEBUG librespot_connect::spirc] drop Spirc[0]
DEBUG librespot_playback::player] Shutting down player thread ...

The only way to connect with a different user us to remove the credentials.json file in the cache folder then restart librespot, but then it's locked into whichever client connects next forever. This makes it difficult for friends and family to make use of librespot.

I'm not sure if this is the same issue or not. Other than the title and basic symptoms it looks different to me. https://github.com/librespot-org/librespot/issues/523 If it matters I use the pipe backend.

Originally created by @mikeszila on GitHub (Jan 24, 2021). Original GitHub issue: https://github.com/librespot-org/librespot/issues/579 I do not use username or password options when starting librespot. I can connect to librespot with multiple different clients as long as they are the same user. If I then try to connect with a client logged in with a different user, librespot crashes. I don't even have to press play for this to happen. Below is the only output when this happens. Previous versions of librespot did not exhibit this behaviour, though I'm not sure when it started. ``` DEBUG librespot_connect::discovery] Post "/" {} DEBUG librespot_connect::spirc] drop Spirc[0] DEBUG librespot_playback::player] Shutting down player thread ... ``` The only way to connect with a different user us to remove the credentials.json file in the cache folder then restart librespot, but then it's locked into whichever client connects next forever. This makes it difficult for friends and family to make use of librespot. I'm not sure if this is the same issue or not. Other than the title and basic symptoms it looks different to me. https://github.com/librespot-org/librespot/issues/523 If it matters I use the pipe backend.

kerem

2026-02-27 19:30:15 +03:00

closed this issue
added the
bug

reverse engineering

can't reproduce
labels

kerem commented

2026-02-27 19:30:16 +03:00

Author

Owner

@mikeszila commented on GitHub (Jan 27, 2021):

Is this considered normal behaviour? Is there anything else I could provide to help convey the issue?

@mikeszila commented on GitHub (Jan 27, 2021): Is this considered normal behaviour? Is there anything else I could provide to help convey the issue?

kerem commented

2026-02-27 19:30:16 +03:00

Author

Owner

@sashahilton00 commented on GitHub (Jan 30, 2021):

Is that built with the latest commit? There were some cache issues that I let slip through in a PR. Doesn't look like the problem that was reported, but deleting credentials.json to resolve suggests it may be related

@sashahilton00 commented on GitHub (Jan 30, 2021): Is that built with the latest commit? There were some cache issues that I let slip through in a PR. Doesn't look like the problem that was reported, but deleting credentials.json to resolve suggests it may be related

kerem commented

2026-02-27 19:30:16 +03:00

Author

Owner

@sashahilton00 commented on GitHub (Feb 6, 2021):

I wonder if github.com/librespot-org/librespot@f67ceb5f6d/connect/src/discovery.rs (L81) is somewhat responsible, in that if a client tries to connect when a user is active, it might send an action such as logoutUser, which removes the active user before logging the new one in. Having said that though, I believe account switching should just work, it shouldn't be sticking with one account forever so to speak.

We may need to investigate further, will tag with reverse engineering for now.

@sashahilton00 commented on GitHub (Feb 6, 2021): I wonder if https://github.com/librespot-org/librespot/blob/f67ceb5f6d955c800564a98f8a4098c7702e8083/connect/src/discovery.rs#L81 is somewhat responsible, in that if a client tries to connect when a user is active, it might send an action such as `logoutUser`, which removes the active user before logging the new one in. Having said that though, I believe account switching should just work, it shouldn't be sticking with one account forever so to speak. We may need to investigate further, will tag with reverse engineering for now.

kerem commented

2026-02-27 19:30:16 +03:00

Author

Owner

@roderickvd commented on GitHub (Jun 14, 2021):

Is this still an issue on vanilla librespot (i.e. not repackaged with ncspot or Spotifyd or the like)? Recently I have tested switching back and forth users and cannot reproduce this.

@roderickvd commented on GitHub (Jun 14, 2021): Is this still an issue on vanilla `librespot` (i.e. not repackaged with `ncspot` or `Spotifyd` or the like)? Recently I have tested switching back and forth users and cannot reproduce this.

kerem commented

2026-02-27 19:30:16 +03:00

Author

Owner

@roderickvd commented on GitHub (Aug 7, 2021):

Closing, no further feedback.

@roderickvd commented on GitHub (Aug 7, 2021): Closing, no further feedback.

kerem referenced this issue

2026-02-27 20:00:46 +03:00

[PR #649] [MERGED] [Tokio migration] Merge dev and refactor #999

kerem referenced this issue

2026-02-27 20:00:47 +03:00

[PR #665] [MERGED] Tokio migration #1006

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#368

No description provided.

Rows
Columns