mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[GH-ISSUE #496] Replace Panics with actual proper error code #314
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#314
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ghost on GitHub (Jun 17, 2020).
Original GitHub issue: https://github.com/librespot-org/librespot/issues/496
in https://github.com/librespot-org/librespot/blob/dev/core/src/connection/mod.rs#L121
when there is an error it returns an Panic. Instead of Panic Can an error code be returned?
P.S. I'm using librespot as a library
@ashthespy commented on GitHub (Jun 17, 2020):
The overall issue of panics is already being tracked in #193, closing this in favour of that..
During the refactor to futures 0.3/async/await, this is one the low hanging fruits that we are trying to grab as well..