[GH-ISSUE #370] Can not compile on latest build due to core library "format!" conflict #245

Closed
opened 2026-02-27 19:29:37 +03:00 by kerem · 3 comments
Owner

Originally created by @xentrick on GitHub (Sep 16, 2019).
Original GitHub issue: https://github.com/librespot-org/librespot/issues/370

Seems that ncspot will not compile on the latest nightly build.

/.cargo/git/checkouts/librespot-06fda9f186b35c32/1ce0706/metadata/src/lib.rs:62:19
   |
62 |         let uri = format!("{}/{}", Self::base_url(), id.to_base16());
   |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ could not find `format_args` in `core`
   |
   = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

This seems related to the following extern as core. The compiler is attempting to locate format! within librespot_core instead of core::fmt

extern crate librespot_core as core;
Originally created by @xentrick on GitHub (Sep 16, 2019). Original GitHub issue: https://github.com/librespot-org/librespot/issues/370 Seems that ncspot will not compile on the latest nightly build. ``` /.cargo/git/checkouts/librespot-06fda9f186b35c32/1ce0706/metadata/src/lib.rs:62:19 | 62 | let uri = format!("{}/{}", Self::base_url(), id.to_base16()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ could not find `format_args` in `core` | = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) ``` This seems related to the following extern as `core`. The compiler is attempting to locate `format!` within `librespot_core` instead of `core::fmt` ``` extern crate librespot_core as core; ```
kerem closed this issue 2026-02-27 19:29:37 +03:00
Author
Owner

@HEnquist commented on GitHub (Sep 16, 2019):

I have a PR with the fix for this issue:
https://github.com/librespot-org/librespot/pull/366
My solution is to skip the "as core" part and use the full name librespot_core. This means that the imports in ncspot have to be changed as well.

<!-- gh-comment-id:531898778 --> @HEnquist commented on GitHub (Sep 16, 2019): I have a PR with the fix for this issue: https://github.com/librespot-org/librespot/pull/366 My solution is to skip the "as core" part and use the full name librespot_core. This means that the imports in ncspot have to be changed as well.
Author
Owner

@xentrick commented on GitHub (Sep 16, 2019):

@HEnquist Thanks, I forked and did the same fix to get it running for myself. Hopefully the changes get merged soon.

<!-- gh-comment-id:531913619 --> @xentrick commented on GitHub (Sep 16, 2019): @HEnquist Thanks, I forked and did the same fix to get it running for myself. Hopefully the changes get merged soon.
Author
Owner

@ashthespy commented on GitHub (Sep 21, 2019):

Fixed by #371

<!-- gh-comment-id:533804563 --> @ashthespy commented on GitHub (Sep 21, 2019): Fixed by #371
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/librespot#245
No description provided.