[GH-ISSUE #322] Fix timealignment subtraction underflow #213

New issue

Closed

opened 2026-02-27 19:29:26 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 19:29:26 +03:00

Owner

Originally created by @medwards on GitHub (Mar 25, 2019).
Original GitHub issue: https://github.com/librespot-org/librespot/issues/322

#321 introduced a panic if the system time is slightly ahead of the server time. medwards/librespot@check_underflow fixes this but I think the intended behaviour is to provide a signed time delta (certainly the code that uses it in connect uses time delta to create a signed delta).

I'm not super happy with the check_underflow branch but I want to go out so just leaving this note if someone wants to fix it before me :)

Originally created by @medwards on GitHub (Mar 25, 2019). Original GitHub issue: https://github.com/librespot-org/librespot/issues/322 #321 introduced a panic if the system time is slightly ahead of the server time. medwards/librespot@check_underflow fixes this but I think the intended behaviour is to provide a signed time delta (certainly the code that uses it in `connect` uses time delta to create a signed delta). I'm not super happy with the `check_underflow` branch but I want to go out so just leaving this note if someone wants to fix it before me :)

kerem closed this issue

2026-02-27 19:29:27 +03:00

kerem referenced this issue

2026-02-27 20:00:09 +03:00

[PR #213] [MERGED] reverse #212 since it does not address the real problem #838

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#213

No description provided.

Rows
Columns