mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[GH-ISSUE #308] Update metadata endpoint #204
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#204
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ashthespy on GitHub (Mar 15, 2019).
Original GitHub issue: https://github.com/librespot-org/librespot/issues/308
Opening up this issue so it's easier to track than gitter ;-)
Currently we still use the
hm://metadata/3/xxendpoints, whereas the official clients use4.Updating to the v4 endpoint will be a prerequisite for podcast support.
I have extracted the following definitions from the official client.
metadata.proto
@sashahilton00 commented on GitHub (Mar 16, 2019):
@ashthespy have you added this in a branch of yours that you're planning to merge, or shall I just add it and create a pr? I believe there were some other proto defs that we could update as well whilst we're at it
@ashthespy commented on GitHub (Mar 21, 2019):
I will have to look - I recall updating it while playing around with podcast support. I also recall that restrictions are handled differently on this endpoint, and needed some investigating. Will look at it when I get home this weekend..
@ashthespy commented on GitHub (Mar 24, 2019):
Some findings so far: https://gist.github.com/ashthespy/b748a5e0538b2e405c04dcb66fb3cd54
tl;dr
v4doesn't give you anyrestrictionsoralternatives- either it gives you the file list or not.@mainrs commented on GitHub (Jul 2, 2019):
Out of curiosity, how do you guys get access to the protocols? :)
@devgianlu commented on GitHub (Jul 2, 2019):
We dump them from the executables.
@mainrs commented on GitHub (Jul 2, 2019):
@devgianlu you mean the desktop client? Aren't those written using electron? I thought that proto files get somehow converted to JS and mangled too...
@devgianlu commented on GitHub (Jul 2, 2019):
The desktop client is written in C (++, I think) and you can totally salvage the proto files with this tool.